Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2373253004:
Return VisualVewport bounds in screen coordinates (DIP) in GpuBenchmarking::VisualViewportXXX method (Closed)
|
Created:
4 years, 2 months ago by oshima Modified:
4 years, 2 months ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, extensions-reviews_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReturn VisualVewport bounds in screen coordinates (DIP) in GpuBenchmarking::VisualViewportXXX method
because telemetry uses it to generate events that are in screen coordinates.
BUG=599656
TEST=run smoothness.top_25_smooth test locally and passed.
Committed: https://crrev.com/927fd323e9ba86831f676db0fc3639eb7c9dba4b
Cr-Commit-Position: refs/heads/master@{#422639}
Patch Set 1 #Patch Set 2 : . #Messages
Total messages: 26 (18 generated)
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
oshima@chromium.org changed reviewers: + bccheng@chromium.org, bokan@chromium.org
Description was changed from ========== Return the viewport side in DIP in GpuBenchmarking::VisualViewportXXX method BUG=599656 ========== to ========== Return the viewport bounds in DIP in GpuBenchmarking::VisualViewportXXX method BUG=599656 ==========
Description was changed from ========== Return the viewport bounds in DIP in GpuBenchmarking::VisualViewportXXX method BUG=599656 ========== to ========== Return the viewport bounds in screen coordinates (DIP) in GpuBenchmarking::VisualViewportXXX method BUG=599656 ==========
Description was changed from ========== Return the viewport bounds in screen coordinates (DIP) in GpuBenchmarking::VisualViewportXXX method BUG=599656 ========== to ========== Return VisualVewport bounds in screen coordinates (DIP) in GpuBenchmarking::VisualViewportXXX method because telemetry uses it to generate events that are in screen coordinates. BUG=599656 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
Description was changed from ========== Return VisualVewport bounds in screen coordinates (DIP) in GpuBenchmarking::VisualViewportXXX method because telemetry uses it to generate events that are in screen coordinates. BUG=599656 ========== to ========== Return VisualVewport bounds in screen coordinates (DIP) in GpuBenchmarking::VisualViewportXXX method because telemetry uses it to generate events that are in screen coordinates. BUG=599656 TEST=run smoothness.top_25_smooth test locally and passed. ==========
oshima@chromium.org changed reviewers: + jbauman@chromium.org
jbauman@ -> owners
rs lgtm
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Return VisualVewport bounds in screen coordinates (DIP) in GpuBenchmarking::VisualViewportXXX method because telemetry uses it to generate events that are in screen coordinates. BUG=599656 TEST=run smoothness.top_25_smooth test locally and passed. ========== to ========== Return VisualVewport bounds in screen coordinates (DIP) in GpuBenchmarking::VisualViewportXXX method because telemetry uses it to generate events that are in screen coordinates. BUG=599656 TEST=run smoothness.top_25_smooth test locally and passed. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Return VisualVewport bounds in screen coordinates (DIP) in GpuBenchmarking::VisualViewportXXX method because telemetry uses it to generate events that are in screen coordinates. BUG=599656 TEST=run smoothness.top_25_smooth test locally and passed. ========== to ========== Return VisualVewport bounds in screen coordinates (DIP) in GpuBenchmarking::VisualViewportXXX method because telemetry uses it to generate events that are in screen coordinates. BUG=599656 TEST=run smoothness.top_25_smooth test locally and passed. Committed: https://crrev.com/927fd323e9ba86831f676db0fc3639eb7c9dba4b Cr-Commit-Position: refs/heads/master@{#422639} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/927fd323e9ba86831f676db0fc3639eb7c9dba4b Cr-Commit-Position: refs/heads/master@{#422639} |
