Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2373253003: Revert of [stubs] Don't unconditionally canonicalize in ChangeFloat64ToTagged. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Jarin, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [stubs] Don't unconditionally canonicalize in ChangeFloat64ToTagged. (patchset #2 id:20001 of https://codereview.chromium.org/2380543002/ ) Reason for revert: Tanks ai-astar in Kraken pretty badly (some deopt loop). Original issue's description: > [stubs] Don't unconditionally canonicalize in ChangeFloat64ToTagged. > > Add a CanonicalizationMode to CodeStubAssembler::ChangeFloat64ToTagged, > so clients can request Smi canonicalization when desired, but otherwise > get Crankshaft/Fullcodegen compatible behavior of just boxing the double > into a HeapNumber. > > R=verwaest@chromium.org > BUG=v8:5268 > > Committed: https://crrev.com/06eef6e6d8199df8317df8469d767092472f3fe0 > Cr-Commit-Position: refs/heads/master@{#39804} TBR=verwaest@chromium.org,jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5268 Committed: https://crrev.com/55bd4f0572218b890c4fd36ece9dfd534d223d7f Cr-Commit-Position: refs/heads/master@{#39812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -73 lines) Patch
M src/code-stub-assembler.h View 2 chunks +1 line, -6 lines 0 comments Download
M src/code-stub-assembler.cc View 2 chunks +47 lines, -67 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Benedikt Meurer
Created Revert of [stubs] Don't unconditionally canonicalize in ChangeFloat64ToTagged.
4 years, 2 months ago (2016-09-28 09:03:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373253003/1
4 years, 2 months ago (2016-09-28 09:03:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 09:03:54 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 09:04:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55bd4f0572218b890c4fd36ece9dfd534d223d7f
Cr-Commit-Position: refs/heads/master@{#39812}

Powered by Google App Engine
This is Rietveld 408576698