Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2373253002: Remove vestigial #ifmac code from fullscreen_controller.cc (Closed)

Created:
4 years, 2 months ago by tapted
Modified:
4 years, 2 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove vestigial #ifmac code from fullscreen_controller.cc There's some code to force an update to the Cocoa UI on Mac, but the Cocoa fullscreen UI is gone now. This isn't needed, and seems to cause some crashes within AppKit window management code on older OS versions because it can be triggered during the closure of the parent window. BUG=650538 TEST=Manually, and ensuring no regressions in `interactive_ui_tests --gtest_filter=FullscreenControllerInteractiveTest.* --gtest_also_run_disabled_tests` Committed: https://crrev.com/1bd32f9d092dca9657f4862916c96df7fb3a202f Cr-Commit-Position: refs/heads/master@{#421743}

Patch Set 1 #

Patch Set 2 : Another vestige #

Patch Set 3 : Restore NotifyTabExclusiveAccessLost() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/ui/exclusive_access/fullscreen_controller.cc View 2 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
tapted
4 years, 2 months ago (2016-09-29 03:29:06 UTC) #13
Matt Giuca
lgtm, please fix CL description: verisons -> versions
4 years, 2 months ago (2016-09-29 03:38:14 UTC) #14
tapted
On 2016/09/29 03:38:14, Matt Giuca wrote: > lgtm, please fix CL description: verisons -> versions ...
4 years, 2 months ago (2016-09-29 03:39:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373253002/40001
4 years, 2 months ago (2016-09-29 03:40:14 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-29 04:08:00 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 04:10:18 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1bd32f9d092dca9657f4862916c96df7fb3a202f
Cr-Commit-Position: refs/heads/master@{#421743}

Powered by Google App Engine
This is Rietveld 408576698