|
|
Chromium Code Reviews|
Created:
4 years, 2 months ago by tapted Modified:
4 years, 2 months ago Reviewers:
Matt Giuca CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove vestigial #ifmac code from fullscreen_controller.cc
There's some code to force an update to the Cocoa UI on Mac, but the
Cocoa fullscreen UI is gone now. This isn't needed, and seems to cause
some crashes within AppKit window management code on older OS versions
because it can be triggered during the closure of the parent window.
BUG=650538
TEST=Manually, and ensuring no regressions in `interactive_ui_tests
--gtest_filter=FullscreenControllerInteractiveTest.*
--gtest_also_run_disabled_tests`
Committed: https://crrev.com/1bd32f9d092dca9657f4862916c96df7fb3a202f
Cr-Commit-Position: refs/heads/master@{#421743}
Patch Set 1 #Patch Set 2 : Another vestige #Patch Set 3 : Restore NotifyTabExclusiveAccessLost() #Messages
Total messages: 23 (17 generated)
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove vestigal #ifmac code from fullscreen_controller.cc There's some code to force an update to the Cocoa UI on Mac, but the Cocoa fullscreen UI is gone now. This isn't needed, and seems to cause some crashes within AppKit window management code because it can be triggered during the closure of the parent window. BUG=650538 ========== to ========== Remove vestigial #ifmac code from fullscreen_controller.cc There's some code to force an update to the Cocoa UI on Mac, but the Cocoa fullscreen UI is gone now. This isn't needed, and seems to cause some crashes within AppKit window management code because it can be triggered during the closure of the parent window. BUG=650538 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove vestigial #ifmac code from fullscreen_controller.cc There's some code to force an update to the Cocoa UI on Mac, but the Cocoa fullscreen UI is gone now. This isn't needed, and seems to cause some crashes within AppKit window management code because it can be triggered during the closure of the parent window. BUG=650538 ========== to ========== Remove vestigial #ifmac code from fullscreen_controller.cc There's some code to force an update to the Cocoa UI on Mac, but the Cocoa fullscreen UI is gone now. This isn't needed, and seems to cause some crashes within AppKit window management code on older OS verisons because it can be triggered during the closure of the parent window. BUG=650538 ==========
Description was changed from ========== Remove vestigial #ifmac code from fullscreen_controller.cc There's some code to force an update to the Cocoa UI on Mac, but the Cocoa fullscreen UI is gone now. This isn't needed, and seems to cause some crashes within AppKit window management code on older OS verisons because it can be triggered during the closure of the parent window. BUG=650538 ========== to ========== Remove vestigial #ifmac code from fullscreen_controller.cc There's some code to force an update to the Cocoa UI on Mac, but the Cocoa fullscreen UI is gone now. This isn't needed, and seems to cause some crashes within AppKit window management code on older OS verisons because it can be triggered during the closure of the parent window. BUG=650538 TEST=Manually, and ensuring no regressions in `interactive_ui_tests --gtest_filter=FullscreenControllerInteractiveTest.* --gtest_also_run_disabled_tests` ==========
tapted@chromium.org changed reviewers: + mgiuca@chromium.org
lgtm, please fix CL description: verisons -> versions
Description was changed from ========== Remove vestigial #ifmac code from fullscreen_controller.cc There's some code to force an update to the Cocoa UI on Mac, but the Cocoa fullscreen UI is gone now. This isn't needed, and seems to cause some crashes within AppKit window management code on older OS verisons because it can be triggered during the closure of the parent window. BUG=650538 TEST=Manually, and ensuring no regressions in `interactive_ui_tests --gtest_filter=FullscreenControllerInteractiveTest.* --gtest_also_run_disabled_tests` ========== to ========== Remove vestigial #ifmac code from fullscreen_controller.cc There's some code to force an update to the Cocoa UI on Mac, but the Cocoa fullscreen UI is gone now. This isn't needed, and seems to cause some crashes within AppKit window management code on older OS versions because it can be triggered during the closure of the parent window. BUG=650538 TEST=Manually, and ensuring no regressions in `interactive_ui_tests --gtest_filter=FullscreenControllerInteractiveTest.* --gtest_also_run_disabled_tests` ==========
On 2016/09/29 03:38:14, Matt Giuca wrote: > lgtm, please fix CL description: verisons -> versions Done.
The CQ bit was unchecked by tapted@chromium.org
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove vestigial #ifmac code from fullscreen_controller.cc There's some code to force an update to the Cocoa UI on Mac, but the Cocoa fullscreen UI is gone now. This isn't needed, and seems to cause some crashes within AppKit window management code on older OS versions because it can be triggered during the closure of the parent window. BUG=650538 TEST=Manually, and ensuring no regressions in `interactive_ui_tests --gtest_filter=FullscreenControllerInteractiveTest.* --gtest_also_run_disabled_tests` ========== to ========== Remove vestigial #ifmac code from fullscreen_controller.cc There's some code to force an update to the Cocoa UI on Mac, but the Cocoa fullscreen UI is gone now. This isn't needed, and seems to cause some crashes within AppKit window management code on older OS versions because it can be triggered during the closure of the parent window. BUG=650538 TEST=Manually, and ensuring no regressions in `interactive_ui_tests --gtest_filter=FullscreenControllerInteractiveTest.* --gtest_also_run_disabled_tests` ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Remove vestigial #ifmac code from fullscreen_controller.cc There's some code to force an update to the Cocoa UI on Mac, but the Cocoa fullscreen UI is gone now. This isn't needed, and seems to cause some crashes within AppKit window management code on older OS versions because it can be triggered during the closure of the parent window. BUG=650538 TEST=Manually, and ensuring no regressions in `interactive_ui_tests --gtest_filter=FullscreenControllerInteractiveTest.* --gtest_also_run_disabled_tests` ========== to ========== Remove vestigial #ifmac code from fullscreen_controller.cc There's some code to force an update to the Cocoa UI on Mac, but the Cocoa fullscreen UI is gone now. This isn't needed, and seems to cause some crashes within AppKit window management code on older OS versions because it can be triggered during the closure of the parent window. BUG=650538 TEST=Manually, and ensuring no regressions in `interactive_ui_tests --gtest_filter=FullscreenControllerInteractiveTest.* --gtest_also_run_disabled_tests` Committed: https://crrev.com/1bd32f9d092dca9657f4862916c96df7fb3a202f Cr-Commit-Position: refs/heads/master@{#421743} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1bd32f9d092dca9657f4862916c96df7fb3a202f Cr-Commit-Position: refs/heads/master@{#421743} |
