Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2373243002: Prune createVisiblePositionDeprecated from endOfParagraphAlgorithm (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune createVisiblePositionDeprecated from endOfParagraphAlgorithm The call of createVisiblePositionDeprecated in endOfParagraphAlgorithm should have been pruned in previous patches but was missed. This patch does it. BUG=647219 Committed: https://crrev.com/ae17e4f7001f6523d0e426028d842f436199fe0f Cr-Commit-Position: refs/heads/master@{#421446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-09-28 03:33:52 UTC) #5
yosin_UTC9
lgtm Oops, sorry I missed too... (^_^;)
4 years, 2 months ago (2016-09-28 03:42:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373243002/1
4 years, 2 months ago (2016-09-28 03:42:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 04:24:06 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 04:26:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae17e4f7001f6523d0e426028d842f436199fe0f
Cr-Commit-Position: refs/heads/master@{#421446}

Powered by Google App Engine
This is Rietveld 408576698