Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 237323002: [NOT FOR REVIEW] Plumb Android GCM to Push API (Closed)

Created:
6 years, 8 months ago by johnme
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

[NOT FOR REVIEW] Plumb Android GCM to Push API Hacky prototype implementation of push messaging on Android. Needs major refactoring before it could be landed. This is a subset of http://crrev.com/226173002 Depends on the following patches: - http://crrev.com/152763002 Bindings and plumbing for push messaging API. - http://crrev.com/195813005 Wire up push message event. - http://crrev.com/236793004 Patches to push messaging for prototype (chromium) BUG=350378

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -3 lines) Patch
A chrome/android/java/src/org/chromium/chrome/browser/GcmPlatformImpl.java View 1 chunk +200 lines, -0 lines 0 comments Download
M chrome/android/shell/java/AndroidManifest.xml View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/browser/android/gcm_android.h View 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/browser/android/gcm_android.cc View 1 chunk +96 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +13 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/signin/ChromeSigninController.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
johnme
4 years, 10 months ago (2016-02-12 15:49:47 UTC) #1 
Description was changed from

==========
[NOT FOR REVIEW] Plumb Android GCM to Push API

Hacky prototype implementation of push messaging on Android.
Needs major refactoring before it could be landed.

This is a subset of http://crrev.com/226173002

Depends on the following patches:
- http://crrev.com/152763002 Bindings and plumbing for push messaging API.
- http://crrev.com/195813005 Wire up push message event.
- http://crrev.com/236793004 Patches to push messaging for prototype (chromium)

BUG=350378
==========

to

==========
[NOT FOR REVIEW] Plumb Android GCM to Push API

Hacky prototype implementation of push messaging on Android.
Needs major refactoring before it could be landed.

This is a subset of http://crrev.com/226173002

Depends on the following patches:
- http://crrev.com/152763002 Bindings and plumbing for push messaging API.
- http://crrev.com/195813005 Wire up push message event.
- http://crrev.com/236793004 Patches to push messaging for prototype (chromium)

BUG=350378
==========

Powered by Google App Engine
This is Rietveld 408576698