Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2373223002: Fieldset should allow whitespaces even though LayoutFlexibleBox doesn't. (Closed)

Created:
4 years, 2 months ago by Gleb Lanbin
Modified:
4 years, 2 months ago
Reviewers:
cbiesinger
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fieldset should allow whitespaces even though LayoutFlexibleBox doesn't. Restore the correct behaviour for canHaveWhitespaceChildren to return true for <fieldset> because it was changed when LayoutFieldSet was switched to use LayoutFlexibleBox. Revert some incorrectly rebaselined tests from https://crrev.com/419570. For example: it's expected to have a trailing empty LayoutText for a fieldset layout object. See fieldset-align-expected.txt BUG=648209 Committed: https://crrev.com/1833c7446ae72fa3437e73e9323c87f89b034c2f Cr-Commit-Position: refs/heads/master@{#421911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -84 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/invalidation/fieldset-disabled-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/fieldset/validation-in-fieldset-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/focus-selection-input-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/focus-selection-textarea-expected.txt View 1 chunk +9 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/validity-property-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/fieldset/fieldset-align-expected.txt View 4 chunks +16 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/forms/focus-selection-textarea-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/fieldset/fieldset-align-expected.txt View 4 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/fieldset/fieldset-align-expected.txt View 4 chunks +16 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/forms/focus-selection-textarea-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/forms/fieldset/fieldset-align-expected.txt View 4 chunks +16 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/forms/focus-selection-textarea-expected.txt View 1 chunk +0 lines, -73 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Gleb Lanbin
4 years, 2 months ago (2016-09-28 17:37:57 UTC) #9
cbiesinger
lgtm
4 years, 2 months ago (2016-09-29 18:43:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373223002/60001
4 years, 2 months ago (2016-09-29 18:44:46 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 2 months ago (2016-09-29 19:59:05 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 20:01:42 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1833c7446ae72fa3437e73e9323c87f89b034c2f
Cr-Commit-Position: refs/heads/master@{#421911}

Powered by Google App Engine
This is Rietveld 408576698