Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2373203002: DevTools: rename useArrayPreviewFormatter and remove ConsoleCommandResult override (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index 3a371180192746cbf40985d9fc711c5858dfce01..e8f454fe02dad45a110c963f07020f2759cf922b 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -587,12 +587,11 @@ WebInspector.ConsoleViewMessage.prototype = {
},
/**
- * @param {!WebInspector.RemoteObject} array
* @return {boolean}
*/
- useArrayPreviewInFormatter: function(array)
+ usePrintedArrayFormatter: function()
lushnikov 2016/09/28 16:54:03 can we make it private?
luoe 2016/09/28 17:50:55 Done.
{
- return this._message.type !== WebInspector.ConsoleMessage.MessageType.DirXML;
+ return this._message.type !== WebInspector.ConsoleMessage.MessageType.DirXML && this._message.type !== WebInspector.ConsoleMessage.MessageType.Result;
},
/**
@@ -602,8 +601,8 @@ WebInspector.ConsoleViewMessage.prototype = {
_formatParameterAsArray: function(array, elem)
{
var maxFlatArrayLength = 100;
- if (this.useArrayPreviewInFormatter(array) || array.arrayLength() > maxFlatArrayLength)
- this._formatParameterAsArrayOrObject(array, elem, this.useArrayPreviewInFormatter(array) || array.arrayLength() <= maxFlatArrayLength);
+ if (this.usePrintedArrayFormatter() || array.arrayLength() > maxFlatArrayLength)
+ this._formatParameterAsArrayOrObject(array, elem, this.usePrintedArrayFormatter() || array.arrayLength() <= maxFlatArrayLength);
else
array.getAllProperties(false, this._printArrayResult.bind(this, array, elem));
},
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698