Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2373203002: DevTools: rename useArrayPreviewFormatter and remove ConsoleCommandResult override (Closed)
Patch Set: rebase cl2patch6 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 595 matching lines...) Expand 10 before | Expand all | Expand 10 after
606 { 606 {
607 this._formatParameterAsObject(object, elem, false); 607 this._formatParameterAsObject(object, elem, false);
608 } 608 }
609 }, 609 },
610 610
611 _formattedParameterAsNodeForTest: function() 611 _formattedParameterAsNodeForTest: function()
612 { 612 {
613 }, 613 },
614 614
615 /** 615 /**
616 * @param {!WebInspector.RemoteObject} array
617 * @return {boolean} 616 * @return {boolean}
618 */ 617 */
619 useArrayPreviewInFormatter: function(array) 618 _usePrintedArrayFormatter: function()
620 { 619 {
621 return this._message.type !== WebInspector.ConsoleMessage.MessageType.Di rXML; 620 return this._message.type !== WebInspector.ConsoleMessage.MessageType.Di rXML && this._message.type !== WebInspector.ConsoleMessage.MessageType.Result;
622 }, 621 },
623 622
624 /** 623 /**
625 * @param {!WebInspector.RemoteObject} array 624 * @param {!WebInspector.RemoteObject} array
626 * @param {!Element} elem 625 * @param {!Element} elem
627 */ 626 */
628 _formatParameterAsArray: function(array, elem) 627 _formatParameterAsArray: function(array, elem)
629 { 628 {
630 var maxFlatArrayLength = 100; 629 var maxFlatArrayLength = 100;
631 if (this.useArrayPreviewInFormatter(array) || array.arrayLength() > maxF latArrayLength) 630 if (this._usePrintedArrayFormatter() || array.arrayLength() > maxFlatArr ayLength)
632 this._formatParameterAsArrayOrObject(array, elem, this.useArrayPrevi ewInFormatter(array) || array.arrayLength() <= maxFlatArrayLength); 631 this._formatParameterAsArrayOrObject(array, elem, this._usePrintedAr rayFormatter() || array.arrayLength() <= maxFlatArrayLength);
633 else 632 else
634 array.getAllProperties(false, this._printArrayResult.bind(this, arra y, elem)); 633 array.getAllProperties(false, this._printArrayResult.bind(this, arra y, elem));
635 }, 634 },
636 635
637 /** 636 /**
638 * @param {!WebInspector.RemoteObject} output 637 * @param {!WebInspector.RemoteObject} output
639 * @param {!Element} elem 638 * @param {!Element} elem
640 */ 639 */
641 _formatParameterAsString: function(output, elem) 640 _formatParameterAsString: function(output, elem)
642 { 641 {
(...skipping 620 matching lines...) Expand 10 before | Expand all | Expand 10 after
1263 { 1262 {
1264 if (!this._element) { 1263 if (!this._element) {
1265 WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this ); 1264 WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this );
1266 this._element.classList.toggle("collapsed", this._collapsed); 1265 this._element.classList.toggle("collapsed", this._collapsed);
1267 } 1266 }
1268 return this._element; 1267 return this._element;
1269 }, 1268 },
1270 1269
1271 __proto__: WebInspector.ConsoleViewMessage.prototype 1270 __proto__: WebInspector.ConsoleViewMessage.prototype
1272 } 1271 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698