Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: appengine/findit/crash/test/findit_for_chromecrash_test.py

Issue 2373133002: [Findit] Update found_project and found_components. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from common import chromium_deps 5 from common import chromium_deps
6 from common.dependency import DependencyRoll 6 from common.dependency import DependencyRoll
7 from crash import detect_regression_range 7 from crash import detect_regression_range
8 from crash import findit_for_chromecrash 8 from crash import findit_for_chromecrash
9 from crash import fracas_parser 9 from crash import fracas_parser
10 from crash import findit_for_crash 10 from crash import findit_for_crash
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 91
92 expected_results = { 92 expected_results = {
93 'found': True, 93 'found': True,
94 'suspected_project': '', 94 'suspected_project': '',
95 'suspected_components': [], 95 'suspected_components': [],
96 'suspected_cls': [dummy_match_result.ToDict()], 96 'suspected_cls': [dummy_match_result.ToDict()],
97 'regression_range': ('50.0.1233.0', '50.0.1234.0'), 97 'regression_range': ('50.0.1233.0', '50.0.1234.0'),
98 } 98 }
99 expected_tag = { 99 expected_tag = {
100 'found_suspects': True, 100 'found_suspects': True,
101 'found_project': False,
102 'found_components': False,
101 'has_regression_range': True, 103 'has_regression_range': True,
102 'solution': 'core_algorithm', 104 'solution': 'core_algorithm',
103 } 105 }
104 106
105 self.assertEqual(expected_results, results) 107 self.assertEqual(expected_results, results)
106 self.assertEqual(expected_tag, tag) 108 self.assertEqual(expected_tag, tag)
107 109
108 results, tag = findit_for_chromecrash.FindCulpritForChromeCrash( 110 results, tag = findit_for_chromecrash.FindCulpritForChromeCrash(
109 'signature', 'win', 'frame1\nframe2', '50.0.1234.0', 111 'signature', 'win', 'frame1\nframe2', '50.0.1234.0',
110 []) 112 [])
111 113
112 expected_results = { 114 expected_results = {
113 'found': False, 115 'found': False,
114 'suspected_project': '', 116 'suspected_project': '',
115 'suspected_components': [], 117 'suspected_components': [],
116 'suspected_cls': [], 118 'suspected_cls': [],
117 'regression_range': None 119 'regression_range': None
118 } 120 }
119 expected_tag = { 121 expected_tag = {
120 'found_suspects': False, 122 'found_suspects': False,
123 'found_project': False,
124 'found_components': False,
121 'has_regression_range': False, 125 'has_regression_range': False,
122 'solution': 'core_algorithm', 126 'solution': 'core_algorithm',
123 } 127 }
124 128
125 self.assertEqual(expected_results, results) 129 self.assertEqual(expected_results, results)
126 self.assertEqual(expected_tag, tag) 130 self.assertEqual(expected_tag, tag)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698