Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: Source/core/testing/Internals.cpp

Issue 237313003: CSS shapes support in Web Inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Code review comment and add test Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/testing/Internals.cpp
diff --git a/Source/core/testing/Internals.cpp b/Source/core/testing/Internals.cpp
index d750094d7fd7e76deb9acdaa2599a501e7ff8e31..b7736e4c31f1e857e17e78677bdf62ef8ddb951e 100644
--- a/Source/core/testing/Internals.cpp
+++ b/Source/core/testing/Internals.cpp
@@ -26,7 +26,6 @@
#include "config.h"
#include "Internals.h"
-
#include <v8.h>
#include "InspectorFrontendClientLocal.h"
#include "InternalProfilers.h"
@@ -813,6 +812,17 @@ PassRefPtrWillBeRawPtr<ClientRectList> Internals::inspectorHighlightRects(Docume
return ClientRectList::create(highlight.quads);
}
+String Internals::inspectorHighlightCSSShapes(Node *node, ExceptionState& exceptionState)
+{
+ if (!node) {
+ exceptionState.throwDOMException(InvalidAccessError, ExceptionMessages::argumentNullOrIncorrectType(1, "Node"));
+ return String();
+ }
+
+ RefPtr<JSONObject> object = node->document().page()->inspectorController().buildObjectForShapeOutside(node->document().frame(), toRenderBox(node->renderer()));
+ return object? object->toJSONString(): String();
apavlov 2014/04/17 16:11:32 whitespace before "?"
Habib Virji 2014/04/17 16:27:02 Done.
+}
+
unsigned Internals::markerCountForNode(Node* node, const String& markerType, ExceptionState& exceptionState)
{
if (!node) {

Powered by Google App Engine
This is Rietveld 408576698