Source/core/rendering/shapes/RasterShape.h - Issue 237313003: CSS shapes support in Web Inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/shapes/RasterShape.h

Issue 237313003: CSS shapes support in Web Inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/shapes/RasterShape.h

diff --git a/Source/core/rendering/shapes/RasterShape.h b/Source/core/rendering/shapes/RasterShape.h

index c66de8472bab1466ab7522134c27de4922e3f879..f5a09d3b189c59de32a2054d56298d9e5d196fcd 100644

--- a/Source/core/rendering/shapes/RasterShape.h

+++ b/Source/core/rendering/shapes/RasterShape.h

@@ -90,6 +90,12 @@ public:

virtual LayoutRect shapeMarginLogicalBoundingBox() const OVERRIDE { return static_cast<LayoutRect>(marginIntervals().bounds()); }

virtual bool isEmpty() const OVERRIDE { return m_intervals->isEmpty(); }

virtual void getExcludedIntervals(LayoutUnit logicalTop, LayoutUnit logicalHeight, SegmentList&) const OVERRIDE;

+ virtual void buildDisplayPaths(DisplayPaths& paths) const OVERRIDE

+ {

+ m_intervals->buildBoundsPath(paths.shape);

+ if (shapeMargin())

+ marginIntervals().buildBoundsPath(paths.marginShape);

+ }

private:

const RasterShapeIntervals& marginIntervals() const;