CSS shapes support in Web Inspector

Source/core/rendering/shapes/RasterShape.cpp

 /*
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above
  *    copyright notice, this list of conditions and the following
  *    disclaimer.
@@ skipping 100 matching lines @@
 {
     m_bounds = IntRect();
     for (int y = minY(); y < maxY(); ++y) {
         const IntShapeInterval& intervalAtY = intervalAt(y);
         if (intervalAtY.isEmpty())
             continue;
         m_bounds.unite(IntRect(intervalAtY.x1(), y, intervalAtY.width(), 1));
     }
 }
 
+void RasterShapeIntervals::buildBoundsPath(Path& path) const
+{
+    for (int y = bounds().y(); y < bounds().maxY(); y++) {

[apavlov, 2014/04/17 16:11:32]

You've got two loops using bounds().maxY() in the termination condition, so
depending on the compiler, you might want to extract it into a local variable to
avoid recalculating it at each iteration.

[Habib Virji, 2014/04/17 16:27:02]

Done.

+        if (intervalAt(y).isEmpty())
+            continue;
+
+        IntShapeInterval extent = intervalAt(y);
+        int endY = y + 1;

[apavlov, 2014/04/17 16:11:32]

This could easily go into the for-initializer

[apavlov, 2014/04/17 16:12:26]

Sorry, it's not visible outside the loop, unlike in JavaScript :)

+        for (; endY < bounds().maxY(); endY++) {
+            if (intervalAt(endY).isEmpty() || intervalAt(endY) != extent)
+                break;
+        }
+        path.addRect(FloatRect(extent.x1(), y, extent.width(), endY - y));
+        y = endY - 1;
+    }
+}
+
 const RasterShapeIntervals& RasterShape::marginIntervals() const
 {
     ASSERT(shapeMargin() >= 0);
     if (!shapeMargin())
         return *m_intervals;
 
     int shapeMarginInt = clampToPositiveInteger(ceil(shapeMargin()));
     int maxShapeMarginInt = std::max(m_marginRectSize.width(), m_marginRectSize.height()) * sqrtf(2);
     if (!m_marginIntervals)
         m_marginIntervals = m_intervals->computeShapeMarginIntervals(std::min(shapeMarginInt, maxShapeMarginInt));
@@ skipping 17 matching lines @@
     y2 = std::min(y2, intervals.bounds().maxY());
     IntShapeInterval excludedInterval;
 
     for (int y = y1; y < y2;  y++)
         excludedInterval.unite(intervals.intervalAt(y));
 
     result.append(LineSegment(excludedInterval.x1(), excludedInterval.x2() + 1));
 }
 
 } // namespace WebCore