CSS shapes support in Web Inspector

Source/core/rendering/shapes/ShapeOutsideInfo.cpp

 /*
  * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above
  *    copyright notice, this list of conditions and the following
  *    disclaimer.
@@ skipping 289 matching lines @@
 
         // Lines that do not overlap the shape should act as if the float
         // wasn't there for layout purposes. So we set the deltas to remove the
         // entire width of the float.
         m_leftMarginBoxDelta = floatMarginBoxWidth;
         m_rightMarginBoxDelta = -floatMarginBoxWidth;
         m_lineOverlapsShape = false;
     }
 }
 
+LayoutRect ShapeOutsideInfo::computedShapePhysicalBoundingBox() const
+{
+    LayoutRect physicalBoundingBox = computedShape().shapeMarginLogicalBoundingBox();
+    physicalBoundingBox.setX(physicalBoundingBox.x() + logicalLeftOffset());
+
+    if (m_renderer.style()->isFlippedBlocksWritingMode())
+        physicalBoundingBox.setY(m_renderer.logicalHeight() - physicalBoundingBox.maxY());
+    else
+        physicalBoundingBox.setY(physicalBoundingBox.y() + logicalTopOffset());
+
+    if (!m_renderer.style()->isHorizontalWritingMode())
+        physicalBoundingBox = physicalBoundingBox.transposedRect();
+    else
+        physicalBoundingBox.setY(physicalBoundingBox.y() + logicalTopOffset());

[apavlov, 2014/05/06 12:08:35]

Great, that's exactly what I meant!

I have a quick question, though. What is the relation between
isFlippedBlocksWritingMode() and m_renderer.style()->isHorizontalWritingMode()?
What if we encounter a situation where (isFlippedBlocksWritingMode() &&
isHorizontalWritingMode())? Then the Y set to (m_renderer.logicalHeight() -
physicalBoundingBox.maxY()) will be overwritten by this (physicalBoundingBox.y()
+ logicalTopOffset()), right?

[Habib Virji, 2014/05/06 12:25:41]

Relation between isFlippedBlocksWritingMode() and isHorizontalWritingMode()
--> It is to understand which direction to draw shapes. Since one shows either
to show text in horizontal and other right/bottom mode. I suppose possibility of
it together is not feasible. But rendering people might be in better option, I
am too novice in this area.  

Then the Y set to (m_renderer.logicalHeight() - physicalBoundingBox.maxY()) will
be overwritten by this (physicalBoundingBox.y() + logicalTopOffset()), right?
--> Yes that's true and that's why previously setY  was set before if condition.
Though possibility of this looks rare. I will do further testing. Since this CL
is landed, will try to upload new patch if encounter any issue to handle that
scenario. Is that okay?

[apavlov, 2014/05/06 12:30:29]

Sure. The best approach here is to try coming up with a test that fails and then
fix the failure.

+
+    return physicalBoundingBox;
 }
+
+FloatPoint ShapeOutsideInfo::shapeToRendererPoint(FloatPoint point) const
+{
+    FloatPoint result = FloatPoint(point.x() + logicalLeftOffset(), point.y() + logicalTopOffset());
+    if (m_renderer.style()->isFlippedBlocksWritingMode())
+        result.setY(m_renderer.logicalHeight() - result.y());
+    if (!m_renderer.style()->isHorizontalWritingMode())
+        result = result.transposedPoint();
+    return result;
+}
+
+FloatSize ShapeOutsideInfo::shapeToRendererSize(FloatSize size) const
+{
+    if (!m_renderer.style()->isHorizontalWritingMode())
+        return size.transposedSize();
+    return size;
+}
+
+}