CSS shapes support in Web Inspector

Source/core/inspector/InspectorDOMAgent.cpp

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 1360 matching lines @@
     array->addItem(quad.p1().y());
     array->addItem(quad.p2().x());
     array->addItem(quad.p2().y());
     array->addItem(quad.p3().x());
     array->addItem(quad.p3().y());
     array->addItem(quad.p4().x());
     array->addItem(quad.p4().y());
     return array.release();
 }
 
+static RefPtr<TypeBuilder::Array<JSONValue> > buildArrayForShapeOutside(PassRefPtr<JSONValue> value)

[pfeldman, 2014/05/01 10:18:50]

I'm not sure I follow what this does. It puts given value into an array and
returns this array. But that's not how it is used below. 

[Habib Virji, 2014/05/01 10:38:07]

Idea is to take a JSONValue put in TypeBuilder::Array and return back as an
argument for setBounds/setShape/setMarginShape. 

+{
+    RefPtr<TypeBuilder::Array<JSONValue> > array = TypeBuilder::Array<JSONValue>::create();
+    array->addItem(value);
+    return array.release();
+}
+
 void InspectorDOMAgent::getBoxModel(ErrorString* errorString, int nodeId, RefPtr<TypeBuilder::DOM::BoxModel>& model)
 {
     Node* node = assertNode(errorString, nodeId);
     if (!node)
         return;
 
     Vector<FloatQuad> quads;
     bool isInlineOrBox = m_overlay->getBoxModel(node, &quads);
     if (!isInlineOrBox) {
         *errorString = "Could not compute box model.";
         return;
     }
 
     RenderObject* renderer = node->renderer();
     LocalFrame* frame = node->document().frame();
     FrameView* view = frame->view();
 
     IntRect boundingBox = pixelSnappedIntRect(view->contentsToRootView(renderer->absoluteBoundingBoxRect()));
     RenderBoxModelObject* modelObject = renderer->isBoxModelObject() ? toRenderBoxModelObject(renderer) : 0;
 
+    RefPtr<TypeBuilder::DOM::ShapeOutsideInfo> shapeOutsideInfo = TypeBuilder::DOM::ShapeOutsideInfo::create()
+        .setBounds(buildArrayForShapeOutside(JSONValue::null()))
+        .setShape(buildArrayForShapeOutside(JSONValue::null()))
+        .setMarginShape(buildArrayForShapeOutside(JSONValue::null()));
+
+    if (renderer->isBox()) {
+        RenderBox* renderBox = toRenderBox(renderer);
+        if (renderBox && renderBox->shapeOutsideInfo()) {
+            RefPtr<JSONObject> shapeOutsideObj = m_overlay->buildObjectForShapeOutside(node);

[pfeldman, 2014/05/01 10:18:50]

I'm confused - why doesn't it return RefPtr<TypeBuilder::DOM::ShapeOutsideInfo>?

[Habib Virji, 2014/05/01 10:38:07]

Ok, i was not sure whether it is correct to use typeBuilder::DOM inside
inspector overlay. Will look into it and update. 

+            shapeOutsideInfo = TypeBuilder::DOM::ShapeOutsideInfo::create()
+                .setBounds(buildArrayForShapeOutside(shapeOutsideObj->getArray("bounds")))
+                .setShape(buildArrayForShapeOutside(shapeOutsideObj->getArray("shape")))
+                .setMarginShape(buildArrayForShapeOutside(shapeOutsideObj->getArray("marginShape")));
+        }
+    }
+
     model = TypeBuilder::DOM::BoxModel::create()
         .setContent(buildArrayForQuad(quads.at(3)))
         .setPadding(buildArrayForQuad(quads.at(2)))
         .setBorder(buildArrayForQuad(quads.at(1)))
         .setMargin(buildArrayForQuad(quads.at(0)))
         .setWidth(modelObject ? adjustForAbsoluteZoom(modelObject->pixelSnappedOffsetWidth(), modelObject) : boundingBox.width())
-        .setHeight(modelObject ? adjustForAbsoluteZoom(modelObject->pixelSnappedOffsetHeight(), modelObject) : boundingBox.height());
+        .setHeight(modelObject ? adjustForAbsoluteZoom(modelObject->pixelSnappedOffsetHeight(), modelObject) : boundingBox.height())
+        .setShapeOutside(shapeOutsideInfo);
 }
 
 void InspectorDOMAgent::getNodeForLocation(ErrorString* errorString, int x, int y, int* nodeId)
 {
     if (!pushDocumentUponHandlelessOperation(errorString))
         return;
 
     Node* node = hoveredNodeForPoint(m_document->frame(), IntPoint(x, y), false);
     if (!node) {
         *errorString = "No node found at given location";
@@ skipping 684 matching lines @@
     if (!m_documentNodeToIdMap.contains(m_document)) {
         RefPtr<TypeBuilder::DOM::Node> root;
         getDocument(errorString, root);
         return errorString->isEmpty();
     }
     return true;
 }
 
 } // namespace WebCore