Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2373123002: Remove JoystickScrollProvider (Closed)

Created:
4 years, 2 months ago by Tima Vaisburd
Modified:
4 years, 2 months ago
Reviewers:
Ted C, mustaq, boliu, Rick Byers
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org, aelias_OOO_until_Jul13, Changwan Ryu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove JoystickScrollProvider JoystickScrollProvider introduced a new scrolling mode that required ContentViewCore to keep state (last motion event position in physical pixels). According to the bug 650351 the right way to fix it is to rewrite the joystick scroll. Thus, removing the current implementation. BUG=650351, 620929

Patch Set 1 #

Patch Set 2 : Removed unit test #

Messages

Total messages: 17 (14 generated)
Tima Vaisburd
PTAL: I went ahead and removed current joystick scroll completely. Please advise whether it is ...
4 years, 2 months ago (2016-09-27 23:47:20 UTC) #12
Tima Vaisburd
4 years, 2 months ago (2016-09-27 23:52:03 UTC) #13
Tima Vaisburd
4 years, 2 months ago (2016-09-28 22:56:27 UTC) #16
On 2016/09/27 23:52:03, Tima Vaisburd wrote:

Closing per https://bugs.chromium.org/p/chromium/issues/detail?id=650351#c4 :
Deletion is premature, we agreed with NVidia on short-term maintenance.

aelias@: last motion event offset could be eliminated by generating synthetic
mousewheel events instead of touch events.

Powered by Google App Engine
This is Rietveld 408576698