chrome/browser/payments/android/component_jni_registrar.h - Issue 2373103002: [Web Payments] Common Payments validation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/payments/android/component_jni_registrar.h

Issue 2373103002: [Web Payments] Common Payments validation (Closed)

Patch Set: Split off moving Mojo file Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentValidator.java ('K') | « chrome/browser/android/chrome_jni_registrar.cc ('k') | chrome/browser/payments/android/component_jni_registrar.cc » ('j') | chrome/browser/payments/android/component_jni_registrar.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.
	please use gerrit instead 2016/10/27 17:14:25 I think it's more typical to see RegisterPaymentVa I think it's more typical to see RegisterPaymentValidator() in a payments-specific file name, like payment_validator_android.h/cc or payments_jni_registrar.h. See https://cs.chromium.org/chromium/src/chrome/browser/autofill/android/personal... and https://cs.chromium.org/chromium/src/components/sync/android/sync_jni_registr... patterns for reference. In addition, it would be great to keep this file in components/payments/android/ similar to sync_jni_registrar.h for example. Do you think that's feasible? Kevin Bailey 2016/10/27 22:17:53 Done. Show quoted text On 2016/10/27 17:14:25, rouslan wrote: > I think it's more typical to see RegisterPaymentValidator() in a > payments-specific file name, like payment_validator_android.h/cc or > payments_jni_registrar.h. See > https://cs.chromium.org/chromium/src/chrome/browser/autofill/android/personal... > and > https://cs.chromium.org/chromium/src/components/sync/android/sync_jni_registr... > patterns for reference. > > In addition, it would be great to keep this file in components/payments/android/ > similar to sync_jni_registrar.h for example. Do you think that's feasible? Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_PAYMENTS_ANDROID_COMPONENT_JNI_REGISTRAR_H_

	6 #define CHROME_BROWSER_PAYMENTS_ANDROID_COMPONENT_JNI_REGISTRAR_H_

	7

	8 #include <jni.h>

	9

	10 bool RegisterPaymentValidator(JNIEnv* env);

	11

	12 #endif // CHROME_BROWSER_PAYMENTS_ANDROID_COMPONENT_JNI_REGISTRAR_H_

OLD	NEW