Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23731010: Move text_elider to gfx. (Closed)

Created:
7 years, 3 months ago by Ben Goodger (Google)
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, sadrul, nkostylev+watch_chromium.org, yusukes+watch_chromium.org, ajwong+watch_chromium.org, Ilya Sherman, miu+watch_chromium.org, extensions-reviews_chromium.org, ben+watch_chromium.org, benjhayden+dwatch_chromium.org, stevenjb+watch_chromium.org, jam, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, chromium-apps-reviews_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, penghuang+watch_chromium.org, oshima+watch_chromium.org, Albert Bodenhamer, rouslan+autofillwatch_chromium.org, tfarina, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, James Su, davemoore+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebase #

Patch Set 4 : Add files #

Patch Set 5 : . #

Patch Set 6 : Update #

Patch Set 7 : Update2 #

Patch Set 8 : Update3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -203 lines) Patch
M ash/system/user/tray_user.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/external_protocol_dialog.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_item_model.cc View 3 4 5 6 7 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_ui_util.cc View 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 3 4 5 6 7 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_cell.mm View 1 2 3 4 5 6 7 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_controller.mm View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/external_protocol_dialog.mm View 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm View 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/status_bubble_mac.mm View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/external_protocol_dialog_delegate.cc View 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/avatar_menu_item_gtk.cc View 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc View 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/content_setting_bubble_gtk.cc View 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/download/download_item_gtk.cc View 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/global_history_menu.cc View 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_util.cc View 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/status_bubble_gtk.cc View 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/login/login_prompt.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/location_bar_util.cc View 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 2 3 4 5 6 7 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc View 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/external_protocol_dialog.cc View 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/global_menu_bar_x11.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 3 4 5 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/navigation_entry_impl.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_login_dialog.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M printing/backend/print_backend.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M printing/print_settings_initializer.cc View 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M printing/printed_document.cc View 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cocoa/menu_controller.mm View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/text/text_elider.cc View 1 2 3 4 5 6 7 7 chunks +14 lines, -14 lines 0 comments Download
M ui/base/text/text_elider_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/canvas_skia.cc View 1 2 3 4 5 6 7 4 chunks +10 lines, -10 lines 0 comments Download
M ui/gfx/render_text.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
A + ui/gfx/text_elider.h View 1 2 3 4 chunks +5 lines, -8 lines 0 comments Download
A + ui/gfx/text_elider.cc View 1 2 3 11 chunks +15 lines, -20 lines 0 comments Download
A + ui/gfx/text_elider_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ui/message_center/cocoa/notification_controller.mm View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M ui/message_center/views/bounded_label.cc View 1 2 3 4 5 6 7 2 chunks +6 lines, -6 lines 0 comments Download
M ui/message_center/views/notification_view.cc View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M ui/ui.gyp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ui_unittests.gypi View 3 4 2 chunks +1 line, -1 line 0 comments Download
M ui/views/controls/label.cc View 1 2 2 chunks +7 lines, -6 lines 0 comments Download
M ui/views/controls/styled_label.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/corewm/tooltip_controller.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/tooltip_manager.cc View 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
7 years, 3 months ago (2013-09-06 23:11:04 UTC) #1
sky
LGTM
7 years, 3 months ago (2013-09-08 02:23:48 UTC) #2
Ben Goodger (Google)
7 years, 3 months ago (2013-09-09 22:16:10 UTC) #3
Message was sent while issue was closed. 
Committed patchset #8 manually as r222106 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698