Source/core/rendering/style/ContentData.h - Issue 23731003: Have ContentData::createRenderer() take a Document reference in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/ContentData.h

Issue 23731003: Have ContentData::createRenderer() take a Document reference in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/style/ContentData.h

diff --git a/Source/core/rendering/style/ContentData.h b/Source/core/rendering/style/ContentData.h

index 00053a764e8b309b673e6d80e68d3f7e68835262..77dd5619e9c260a7396d9326eebfd9794e064b3c 100644

--- a/Source/core/rendering/style/ContentData.h

+++ b/Source/core/rendering/style/ContentData.h

@@ -51,7 +51,7 @@ public:

virtual bool isQuote() const { return false; }

virtual bool isText() const { return false; }

- virtual RenderObject* createRenderer(Document*, RenderStyle*) const = 0;

+ virtual RenderObject* createRenderer(Document&, RenderStyle*) const = 0;

virtual PassOwnPtr<ContentData> clone() const;

@@ -74,7 +74,7 @@ public:

void setImage(PassRefPtr<StyleImage> image) { m_image = image; }

virtual bool isImage() const OVERRIDE { return true; }

- virtual RenderObject* createRenderer(Document*, RenderStyle*) const OVERRIDE;

+ virtual RenderObject* createRenderer(Document&, RenderStyle*) const OVERRIDE;

virtual bool equals(const ContentData& data) const OVERRIDE

{

@@ -105,7 +105,7 @@ public:

void setText(const String& text) { m_text = text; }

virtual bool isText() const OVERRIDE { return true; }

- virtual RenderObject* createRenderer(Document*, RenderStyle*) const OVERRIDE;

+ virtual RenderObject* createRenderer(Document&, RenderStyle*) const OVERRIDE;

virtual bool equals(const ContentData& data) const OVERRIDE

{

@@ -132,7 +132,7 @@ public:

void setCounter(PassOwnPtr<CounterContent> counter) { m_counter = counter; }

virtual bool isCounter() const OVERRIDE { return true; }

- virtual RenderObject* createRenderer(Document*, RenderStyle*) const OVERRIDE;

+ virtual RenderObject* createRenderer(Document&, RenderStyle*) const OVERRIDE;

private:

CounterContentData(PassOwnPtr<CounterContent> counter)

@@ -163,7 +163,7 @@ public:

void setQuote(QuoteType quote) { m_quote = quote; }

virtual bool isQuote() const OVERRIDE { return true; }

- virtual RenderObject* createRenderer(Document*, RenderStyle*) const OVERRIDE;

+ virtual RenderObject* createRenderer(Document&, RenderStyle*) const OVERRIDE;

virtual bool equals(const ContentData& data) const OVERRIDE

{

« no previous file with comments | « Source/core/dom/PseudoElement.cpp ('k') | Source/core/rendering/style/ContentData.cpp » ('j') | no next file with comments »