(reland) Add tests for PaintPropertyTreePrinter, remove path printers

(reland) Add tests for PaintPropertyTreePrinter, remove path printers

This patch adds some basic testing of PaintPropertyTreePrinter which
ensures trees can be print with and without root layer scrolling.
Regular expressions have been used to focus on the tree structure and
avoid dynamic output (e.g., pointer values).

I am not aware of anyone using the path printers and have removed them
to keep PaintPropertyTreePrinter lean & mean.

This is a reland of [1] which was rolled out due to colliding with
root property node patches. The updated patch no longer has different
tests for root layer scrolls and non-root layer scrolls, showing that
those patches actually worked.

[1] https://crrev.com/900408123237980d6b583c24b7e64d3b446910e8

BUG=645615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/a08dcd0cb471c6f7bced2291892bc1008aaa8890
Cr-Commit-Position: refs/heads/master@{#421344}

[pdr., 2016-09-27 18:40:09]

Description was changed from

==========
(reland) Add tests for PaintPropertyTreePrinter, remove path printers

This patch adds some basic testing of PaintPropertyTreePrinter which
ensures trees can be print with and without root layer scrolling.
Regular expressions have been used to focus on the tree structure and
avoid dynamic output (e.g., pointer values).

I am not aware of anyone using the path printers and have removed them
to keep PaintPropertyTreePrinter lean & mean.

This is a reland of [1] which was rolled out due to colliding with
root property node patches. The updated patch no longer has different
tests for root layer scrolls and non-root layer scrolls, showing that
those patches actually worked.

[1] https://crrev.com/900408123237980d6b583c24b7e64d3b446910e8

BUG=645615
==========

to

==========
(reland) Add tests for PaintPropertyTreePrinter, remove path printers

This patch adds some basic testing of PaintPropertyTreePrinter which
ensures trees can be print with and without root layer scrolling.
Regular expressions have been used to focus on the tree structure and
avoid dynamic output (e.g., pointer values).

I am not aware of anyone using the path printers and have removed them
to keep PaintPropertyTreePrinter lean & mean.

This is a reland of [1] which was rolled out due to colliding with
root property node patches. The updated patch no longer has different
tests for root layer scrolls and non-root layer scrolls, showing that
those patches actually worked.

[1] https://crrev.com/900408123237980d6b583c24b7e64d3b446910e8

BUG=645615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2016-09-27 18:40:40]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, szager@chromium.org

[pdr., 2016-09-27 18:41:43]

This is a reland due to colliding with the root node patches yesterday. The only
code change is that the tests no longer have two codepaths for RLS and non-RLS.

Whoever gets to this first, please go ahead and CQ + LGTM.

[chrishtr, 2016-09-27 19:00:38]

lgtm

[pdr., 2016-09-27 19:57:25]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2016-09-27 19:57:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 21:41:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-27 21:45:10]

Description was changed from

==========
(reland) Add tests for PaintPropertyTreePrinter, remove path printers

This patch adds some basic testing of PaintPropertyTreePrinter which
ensures trees can be print with and without root layer scrolling.
Regular expressions have been used to focus on the tree structure and
avoid dynamic output (e.g., pointer values).

I am not aware of anyone using the path printers and have removed them
to keep PaintPropertyTreePrinter lean & mean.

This is a reland of [1] which was rolled out due to colliding with
root property node patches. The updated patch no longer has different
tests for root layer scrolls and non-root layer scrolls, showing that
those patches actually worked.

[1] https://crrev.com/900408123237980d6b583c24b7e64d3b446910e8

BUG=645615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
(reland) Add tests for PaintPropertyTreePrinter, remove path printers

This patch adds some basic testing of PaintPropertyTreePrinter which
ensures trees can be print with and without root layer scrolling.
Regular expressions have been used to focus on the tree structure and
avoid dynamic output (e.g., pointer values).

I am not aware of anyone using the path printers and have removed them
to keep PaintPropertyTreePrinter lean & mean.

This is a reland of [1] which was rolled out due to colliding with
root property node patches. The updated patch no longer has different
tests for root layer scrolls and non-root layer scrolls, showing that
those patches actually worked.

[1] https://crrev.com/900408123237980d6b583c24b7e64d3b446910e8

BUG=645615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/a08dcd0cb471c6f7bced2291892bc1008aaa8890
Cr-Commit-Position: refs/heads/master@{#421344}
==========

[commit-bot: I haz the power, 2016-09-27 21:45:11]

Patchset 1 (id:??) landed as
https://crrev.com/a08dcd0cb471c6f7bced2291892bc1008aaa8890
Cr-Commit-Position: refs/heads/master@{#421344}

[Xianzhu, 2016-09-28 22:53:14]

Just noticed the path printer was removed when I tried to use it :(

It's useful when we have a paint property node but don't have a FrameView in
platform/ context, and want to show the affecting nodes.
Perhaps it would be more useful to print the all paths of a
GeometryPropertyTreeState. Wdyt?

[pdr., 2016-09-28 23:20:24]

On 2016/09/28 at 22:53:14, wangxianzhu wrote:
> Just noticed the path printer was removed when I tried to use it :(
> 
> It's useful when we have a paint property node but don't have a FrameView in
platform/ context, and want to show the affecting nodes.
> Perhaps it would be more useful to print the all paths of a
GeometryPropertyTreeState. Wdyt?

Sorry about that, I'll add it back right now. I didn't realize you were using
it.

I'm a little sad about having GeometryPropertyTreeState and
PaintPropertyTreeState. The (soon to be) only difference will be that
PaintPropertyTreeState also has a ScrollPropertyNode. If possible, I'd like to
add printers that support both (like the path printers) until we can somehow
unify these two structs.