Clean up most style warnings in webkitpy/style/checker_unittest.py.

Clean up most style warnings in webkitpy/style/checker_unittest.py.

BUG=643937
Committed: https://crrev.com/e8cbec24369a869717603e32d9d4ffd4fbc64264
Cr-Commit-Position: refs/heads/master@{#421308}

[qyearsley, 2016-09-27 17:15:28]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[qyearsley, 2016-09-27 17:15:31]

https://codereview.chromium.org/2373063002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py
(right):

https://codereview.chromium.org/2373063002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py:74:
is_verbose = False
Adding this line adds a default value for self.is_verbose, which is used in
setUp.

https://codereview.chromium.org/2373063002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py:219:
assert_check(path, "whitespace/carriage_return")
These helper function names are changed to fit the general name convention of
lower_with_underscore.

https://codereview.chromium.org/2373063002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py:642:
self.lines = None
(This line is added so that attributes are all defined in __init__)

[qyearsley, 2016-09-27 17:17:06]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 17:17:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 18:15:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 18:15:49]

Dry run: This issue passed the CQ dry run.

[jeffcarp, 2016-09-27 18:59:08]

On 2016/09/27 at 17:15:31, qyearsley wrote:
>
https://codereview.chromium.org/2373063002/diff/1/third_party/WebKit/Tools/Sc...
> File third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py
(right):
> 
>
https://codereview.chromium.org/2373063002/diff/1/third_party/WebKit/Tools/Sc...
> third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py:74:
is_verbose = False
> Adding this line adds a default value for self.is_verbose, which is used in
setUp.
> 
>
https://codereview.chromium.org/2373063002/diff/1/third_party/WebKit/Tools/Sc...
> third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py:219:
assert_check(path, "whitespace/carriage_return")
> These helper function names are changed to fit the general name convention of
lower_with_underscore.
> 
>
https://codereview.chromium.org/2373063002/diff/1/third_party/WebKit/Tools/Sc...
> third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py:642:
self.lines = None
> (This line is added so that attributes are all defined in __init__)

LGTM

[qyearsley, 2016-09-27 19:50:04]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-09-27 19:50:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 19:57:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-27 19:59:56]

Description was changed from

==========
Clean up most style warnings in webkitpy/style/checker_unittest.py.

BUG=643937
==========

to

==========
Clean up most style warnings in webkitpy/style/checker_unittest.py.

BUG=643937

Committed: https://crrev.com/e8cbec24369a869717603e32d9d4ffd4fbc64264
Cr-Commit-Position: refs/heads/master@{#421308}
==========

[commit-bot: I haz the power, 2016-09-27 19:59:56]

Patchset 1 (id:??) landed as
https://crrev.com/e8cbec24369a869717603e32d9d4ffd4fbc64264
Cr-Commit-Position: refs/heads/master@{#421308}