Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2373043002:
[test] Make test runner more rubust on startup. (Closed)
|
Created:
4 years, 2 months ago by Michael Achenbach Modified:
4 years, 2 months ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[test] Make test runner more rubust on startup.
The test driver fails once in a while with no output when
listing the tests on windows, causing the testing to not
even start.
This should make that less likely if there's a flaky crash
when listing the tests.
BUG=v8:5438
Committed: https://crrev.com/4f02ff7ee54a5fee4f66cc1e0a254f15eb6d4ec1
Cr-Commit-Position: refs/heads/master@{#39779}
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [test] Make test runner more rubust on startup. BUG= ========== to ========== [test] Make test runner more rubust on startup. The test driver fails once in a while with no output when listing the tests on windows, causing the testing to not even start. This should make that less likely if there's a flaky crash when listing the tests. ==========
machenbach@chromium.org changed reviewers: + jkummerow@chromium.org, jochen@chromium.org
PTAL Failed here and there lately, like: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds... https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%2...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm can you file a tracking bug? we shouldn't crash when listing tests...
Description was changed from ========== [test] Make test runner more rubust on startup. The test driver fails once in a while with no output when listing the tests on windows, causing the testing to not even start. This should make that less likely if there's a flaky crash when listing the tests. ========== to ========== [test] Make test runner more rubust on startup. The test driver fails once in a while with no output when listing the tests on windows, causing the testing to not even start. This should make that less likely if there's a flaky crash when listing the tests. BUG=v8:5438 ==========
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [test] Make test runner more rubust on startup. The test driver fails once in a while with no output when listing the tests on windows, causing the testing to not even start. This should make that less likely if there's a flaky crash when listing the tests. BUG=v8:5438 ========== to ========== [test] Make test runner more rubust on startup. The test driver fails once in a while with no output when listing the tests on windows, causing the testing to not even start. This should make that less likely if there's a flaky crash when listing the tests. BUG=v8:5438 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [test] Make test runner more rubust on startup. The test driver fails once in a while with no output when listing the tests on windows, causing the testing to not even start. This should make that less likely if there's a flaky crash when listing the tests. BUG=v8:5438 ========== to ========== [test] Make test runner more rubust on startup. The test driver fails once in a while with no output when listing the tests on windows, causing the testing to not even start. This should make that less likely if there's a flaky crash when listing the tests. BUG=v8:5438 Committed: https://crrev.com/4f02ff7ee54a5fee4f66cc1e0a254f15eb6d4ec1 Cr-Commit-Position: refs/heads/master@{#39779} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4f02ff7ee54a5fee4f66cc1e0a254f15eb6d4ec1 Cr-Commit-Position: refs/heads/master@{#39779}
Message was sent while issue was closed.
Meh - this didn't help much: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%2...
Message was sent while issue was closed.
Ah - maybe printing the return code helped a bit. According to web sources, -1073741515 = 0xC0000135 = STATUS_DLL_NOT_FOUND, which suggests that some sdk dlls might be missing on the target bot. Will investigate more. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
