|
|
DescriptionRemove call to MessageLoop::QuitWhenIdle() in auto_thread.cc.
MessageLoop::QuitWhenIdle() is deprecated. RunLoop should be used
instead.
BUG=616447
Committed: https://crrev.com/fb4e32fc88050cd82bdb74edc90fb4fe3dfe56e7
Cr-Commit-Position: refs/heads/master@{#421313}
Patch Set 1 #Patch Set 2 : fix build error #
Total comments: 2
Patch Set 3 : CR sergeyu #12 #Patch Set 4 : fix test error #Messages
Total messages: 24 (16 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
fdoray@chromium.org changed reviewers: + lambroslambrou@chromium.org
PTAL
sergeyu@chromium.org changed reviewers: + sergeyu@chromium.org
lgtm https://codereview.chromium.org/2373033002/diff/20001/remoting/base/auto_thre... File remoting/base/auto_thread.cc (right): https://codereview.chromium.org/2373033002/diff/20001/remoting/base/auto_thre... remoting/base/auto_thread.cc:165: scoped_refptr<base::SingleThreadTaskRunner> task_runner, This parameter is used only in the DCHECK. Maybe replace it with base::PlatformThreadRef?
https://codereview.chromium.org/2373033002/diff/20001/remoting/base/auto_thre... File remoting/base/auto_thread.cc (right): https://codereview.chromium.org/2373033002/diff/20001/remoting/base/auto_thre... remoting/base/auto_thread.cc:165: scoped_refptr<base::SingleThreadTaskRunner> task_runner, On 2016/09/27 17:36:56, Sergey Ulanov wrote: > This parameter is used only in the DCHECK. Maybe replace it with > base::PlatformThreadRef? Actually, ThreadChecker is the right solution for this. Done.
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org Link to the patchset: https://codereview.chromium.org/2373033002/#ps40001 (title: "CR sergeyu #12")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org Link to the patchset: https://codereview.chromium.org/2373033002/#ps60001 (title: "fix test error")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Remove call to MessageLoop::QuitWhenIdle() in auto_thread.cc. MessageLoop::QuitWhenIdle() is deprecated. RunLoop should be used instead. BUG=616447 ========== to ========== Remove call to MessageLoop::QuitWhenIdle() in auto_thread.cc. MessageLoop::QuitWhenIdle() is deprecated. RunLoop should be used instead. BUG=616447 Committed: https://crrev.com/fb4e32fc88050cd82bdb74edc90fb4fe3dfe56e7 Cr-Commit-Position: refs/heads/master@{#421313} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/fb4e32fc88050cd82bdb74edc90fb4fe3dfe56e7 Cr-Commit-Position: refs/heads/master@{#421313} |