Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 2373033002: Remove call to MessageLoop::QuitWhenIdle() in auto_thread.cc. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
Sergey Ulanov, Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove call to MessageLoop::QuitWhenIdle() in auto_thread.cc. MessageLoop::QuitWhenIdle() is deprecated. RunLoop should be used instead. BUG=616447 Committed: https://crrev.com/fb4e32fc88050cd82bdb74edc90fb4fe3dfe56e7 Cr-Commit-Position: refs/heads/master@{#421313}

Patch Set 1 #

Patch Set 2 : fix build error #

Total comments: 2

Patch Set 3 : CR sergeyu #12 #

Patch Set 4 : fix test error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M remoting/base/auto_thread.h View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M remoting/base/auto_thread.cc View 1 2 3 7 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
fdoray
PTAL
4 years, 2 months ago (2016-09-27 15:03:27 UTC) #10
Sergey Ulanov
lgtm https://codereview.chromium.org/2373033002/diff/20001/remoting/base/auto_thread.cc File remoting/base/auto_thread.cc (right): https://codereview.chromium.org/2373033002/diff/20001/remoting/base/auto_thread.cc#newcode165 remoting/base/auto_thread.cc:165: scoped_refptr<base::SingleThreadTaskRunner> task_runner, This parameter is used only in ...
4 years, 2 months ago (2016-09-27 17:36:56 UTC) #12
fdoray
https://codereview.chromium.org/2373033002/diff/20001/remoting/base/auto_thread.cc File remoting/base/auto_thread.cc (right): https://codereview.chromium.org/2373033002/diff/20001/remoting/base/auto_thread.cc#newcode165 remoting/base/auto_thread.cc:165: scoped_refptr<base::SingleThreadTaskRunner> task_runner, On 2016/09/27 17:36:56, Sergey Ulanov wrote: > ...
4 years, 2 months ago (2016-09-27 19:05:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373033002/40001
4 years, 2 months ago (2016-09-27 19:06:05 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/303714)
4 years, 2 months ago (2016-09-27 19:18:21 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373033002/60001
4 years, 2 months ago (2016-09-27 19:43:44 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-27 20:12:32 UTC) #22
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 20:15:22 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fb4e32fc88050cd82bdb74edc90fb4fe3dfe56e7
Cr-Commit-Position: refs/heads/master@{#421313}

Powered by Google App Engine
This is Rietveld 408576698