Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1967)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h

Issue 2373023002: Make DOM.getChildNodes & DOM.getDocument optionally pierce iframe boundaries (Closed)
Patch Set: Per IM conversation, let DOM.getDocument optionally return the sub tree as well. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
index 46972ca875958a62bee88df2eae67a9678011990..f4666069a32bacd5b27c0e133e2b0d3b944a8713 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
@@ -121,6 +121,8 @@ class CORE_EXPORT InspectorDOMAgent final
void enable(ErrorString*) override;
void disable(ErrorString*) override;
void getDocument(ErrorString*,
+ const Maybe<int>& depth,
+ const Maybe<bool>& traverseFrames,
std::unique_ptr<protocol::DOM::Node>* root) override;
void collectClassNamesFromSubtree(
ErrorString*,
@@ -128,7 +130,8 @@ class CORE_EXPORT InspectorDOMAgent final
std::unique_ptr<protocol::Array<String>>* classNames) override;
void requestChildNodes(ErrorString*,
int nodeId,
- const Maybe<int>& depth) override;
+ const Maybe<int>& depth,
+ const Maybe<bool>& traverseFrames) override;
void querySelector(ErrorString*,
int nodeId,
const String& selector,
@@ -372,6 +375,7 @@ class CORE_EXPORT InspectorDOMAgent final
Member<InspectorHistory> m_history;
Member<DOMEditor> m_domEditor;
bool m_suppressAttributeModifiedEvent;
+ bool m_traverseFrames;
int m_backendNodeIdToInspect;
};

Powered by Google App Engine
This is Rietveld 408576698