Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h

Issue 2373023002: Make DOM.getChildNodes & DOM.getDocument optionally pierce iframe boundaries (Closed)
Patch Set: Added a requestFrames parameter to fix the broken test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
index fc8c264fbee6d8a73b0470a6766aaa0ee381cb52..ce717931c52f1aaa36defda7747f1d97ca233bbd 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
@@ -110,7 +110,7 @@ public:
void disable(ErrorString*) override;
void getDocument(ErrorString*, std::unique_ptr<protocol::DOM::Node>* root) override;
void collectClassNamesFromSubtree(ErrorString*, int nodeId, std::unique_ptr<protocol::Array<String>>* classNames) override;
- void requestChildNodes(ErrorString*, int nodeId, const Maybe<int>& depth) override;
+ void requestChildNodes(ErrorString*, int nodeId, const Maybe<int>& depth, const Maybe<bool>& traverseFrames) override;
void querySelector(ErrorString*, int nodeId, const String& selector, int* outNodeId) override;
void querySelectorAll(ErrorString*, int nodeId, const String& selector, std::unique_ptr<protocol::Array<int>>* nodeIds) override;
void setNodeName(ErrorString*, int nodeId, const String& name, int* outNodeId) override;
@@ -256,6 +256,7 @@ private:
Member<InspectorHistory> m_history;
Member<DOMEditor> m_domEditor;
bool m_suppressAttributeModifiedEvent;
+ bool m_traverseFrames;
int m_backendNodeIdToInspect;
};

Powered by Google App Engine
This is Rietveld 408576698