Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h

Issue 2373023002: Make DOM.getChildNodes & DOM.getDocument optionally pierce iframe boundaries (Closed)
Patch Set: Nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
index 32d10c0905cae9a7315a639d715a71d2d1bd0889..3376c2efd9162f39197ad82d59649a532abc0969 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
@@ -121,6 +121,8 @@ class CORE_EXPORT InspectorDOMAgent final
void enable(ErrorString*) override;
void disable(ErrorString*) override;
void getDocument(ErrorString*,
+ const Maybe<int>& depth,
+ const Maybe<bool>& traverseFrames,
std::unique_ptr<protocol::DOM::Node>* root) override;
void getLayoutTreeNodes(
ErrorString*,
@@ -132,7 +134,8 @@ class CORE_EXPORT InspectorDOMAgent final
std::unique_ptr<protocol::Array<String>>* classNames) override;
void requestChildNodes(ErrorString*,
int nodeId,
- const Maybe<int>& depth) override;
+ const Maybe<int>& depth,
+ const Maybe<bool>& traverseFrames) override;
void querySelector(ErrorString*,
int nodeId,
const String& selector,
@@ -322,18 +325,22 @@ class CORE_EXPORT InspectorDOMAgent final
Element* assertEditableElement(ErrorString*, int nodeId);
int pushNodePathToFrontend(Node*, NodeToIdMap* nodeMap);
- void pushChildNodesToFrontend(int nodeId, int depth = 1);
+ void pushChildNodesToFrontend(int nodeId,
+ int depth = 1,
+ bool traverseFrames = false);
void invalidateFrameOwnerElement(LocalFrame*);
std::unique_ptr<protocol::DOM::Node> buildObjectForNode(Node*,
int depth,
+ bool traverseFrames,
NodeToIdMap*);
std::unique_ptr<protocol::Array<String>> buildArrayForElementAttributes(
Element*);
std::unique_ptr<protocol::Array<protocol::DOM::Node>>
buildArrayForContainerChildren(Node* container,
int depth,
+ bool traverseFrames,
NodeToIdMap* nodesMap);
std::unique_ptr<protocol::Array<protocol::DOM::Node>>
buildArrayForPseudoElements(Element*, NodeToIdMap* nodesMap);

Powered by Google App Engine
This is Rietveld 408576698