Make DOM.getChildNodes & DOM.getDocument optionally pierce iframe boundaries

third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 232 matching lines @@
 
 InspectorDOMAgent::InspectorDOMAgent(v8::Isolate* isolate, InspectedFrames* inspectedFrames, v8_inspector::V8InspectorSession* v8Session, Client* client)
     : m_isolate(isolate)
     , m_inspectedFrames(inspectedFrames)
     , m_v8Session(v8Session)
     , m_client(client)
     , m_domListener(nullptr)
     , m_documentNodeToIdMap(new NodeToIdMap())
     , m_lastNodeId(1)
     , m_suppressAttributeModifiedEvent(false)
+    , m_traverseFrames(false)
     , m_backendNodeIdToInspect(0)
 {
 }
 
 InspectorDOMAgent::~InspectorDOMAgent()
 {
 }
 
 void InspectorDOMAgent::restore()
 {
@@ skipping 273 matching lines @@
         return;
 
     NodeToIdMap* nodeMap = m_idToNodesMap.get(nodeId);
 
     if (m_childrenRequested.contains(nodeId)) {
         if (depth <= 1)
             return;
 
         depth--;
 
+        if (m_traverseFrames && node->isFrameOwnerElement()) {
+            int iframeDocumentId = nodeMap->get(toHTMLFrameOwnerElement(node)->contentDocument()->documentElement());
+            CHECK(iframeDocumentId);
+            pushChildNodesToFrontend(iframeDocumentId, depth);
+        }
         for (node = innerFirstChild(node); node; node = innerNextSibling(node)) {
             int childNodeId = nodeMap->get(node);
-            ASSERT(childNodeId);
+            CHECK(childNodeId);
             pushChildNodesToFrontend(childNodeId, depth);
         }
 
         return;
     }
 
     std::unique_ptr<protocol::Array<protocol::DOM::Node>> children = buildArrayForContainerChildren(node, depth, nodeMap);
     frontend()->setChildNodes(nodeId, std::move(children));
 }
 
@@ skipping 40 matching lines @@
                 continue;
             const SpaceSplitString& classNameList = element.classNames();
             for (unsigned i = 0; i < classNameList.size(); ++i)
                 uniqueNames.add(classNameList[i]);
         }
     }
     for (const String& className : uniqueNames)
         (*classNames)->addItem(className);
 }
 
-void InspectorDOMAgent::requestChildNodes(ErrorString* errorString, int nodeId, const Maybe<int>& depth)
+void InspectorDOMAgent::requestChildNodes(ErrorString* errorString, int nodeId, const Maybe<int>& depth, const Maybe<bool>& traverseFrames)
 {
     int sanitizedDepth = depth.fromMaybe(1);
     if (sanitizedDepth == 0 || sanitizedDepth < -1) {
         *errorString = "Please provide a positive integer as a depth or -1 for entire subtree";
         return;
     }
+    bool prevMayCrossIframeBoundary = m_traverseFrames;
     if (sanitizedDepth == -1)
         sanitizedDepth = INT_MAX;
 
+    m_traverseFrames = traverseFrames.fromMaybe(false);
+
+    // Cached results may not be valid if |m_traverseFrames| changes.
+    if (prevMayCrossIframeBoundary != m_traverseFrames)
+        m_childrenRequested.clear();
+
     pushChildNodesToFrontend(nodeId, sanitizedDepth);
 }
 
 void InspectorDOMAgent::querySelector(ErrorString* errorString, int nodeId, const String& selectors, int* elementId)
 {
     *elementId = 0;
     Node* node = assertNode(errorString, nodeId);
     if (!node || !node->isContainerNode())
         return;
 
@@ skipping 968 matching lines @@
             children->addItem(buildObjectForNode(firstChild, 0, nodesMap));
             m_childrenRequested.add(bind(container, nodesMap));
         }
         return children;
     }
 
     Node* child = innerFirstChild(container);
     depth--;
     m_childrenRequested.add(bind(container, nodesMap));
 
+    if (m_traverseFrames && container->isFrameOwnerElement()) {
+        Node* iframeDocument = toHTMLFrameOwnerElement(container)->contentDocument()->documentElement();
+        children->addItem(buildObjectForNode(iframeDocument, depth, nodesMap));

[pfeldman, 2016/09/27 18:37:41]

Those are not the children, you should report iframe's document under
contentDocument instead.

[alex clarke (OOO till 29th), 2016/09/28 14:30:00]

Done.

+    }
     while (child) {
         children->addItem(buildObjectForNode(child, depth, nodesMap));
         child = innerNextSibling(child);
     }
     return children;
 }
 
 std::unique_ptr<protocol::Array<protocol::DOM::Node>> InspectorDOMAgent::buildArrayForPseudoElements(Element* element, NodeToIdMap* nodesMap)
 {
     if (!element->pseudoElement(PseudoIdBefore) && !element->pseudoElement(PseudoIdAfter))
@@ skipping 512 matching lines @@
     visitor->trace(m_idToNodesMap);
     visitor->trace(m_document);
     visitor->trace(m_revalidateTask);
     visitor->trace(m_searchResults);
     visitor->trace(m_history);
     visitor->trace(m_domEditor);
     InspectorBaseAgent::trace(visitor);
 }
 
 } // namespace blink