Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2860)

Unified Diff: net/url_request/url_request_http_job.h

Issue 2373003003: Switch to use net::FilterSourceStream from net::Filter (Closed)
Patch Set: Edit url_data_manager_backend.cc Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_http_job.h
diff --git a/net/url_request/url_request_http_job.h b/net/url_request/url_request_http_job.h
index f047e447742fd4dedb1c97fad786b978f615d630..7a78750764b531025d032eb06b177b655426a624 100644
--- a/net/url_request/url_request_http_job.h
+++ b/net/url_request/url_request_http_job.h
@@ -22,7 +22,7 @@
#include "net/base/net_export.h"
#include "net/base/sdch_manager.h"
#include "net/cookies/cookie_store.h"
-#include "net/filter/filter.h"
+#include "net/filter/sdch_policy_delegate.h"
#include "net/http/http_request_info.h"
#include "net/socket/connection_attempts.h"
#include "net/url_request/url_request_job.h"
@@ -60,6 +60,7 @@ class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
void Start() override;
void Kill() override;
void GetConnectionAttempts(ConnectionAttempts* out) const override;
+ std::unique_ptr<SourceStream> SetUpSourceStream() override;
RequestPriority priority() const {
return priority_;
@@ -73,7 +74,7 @@ class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
typedef base::RefCountedData<bool> SharedBoolean;
- class HttpFilterContext;
+ class SdchContext;
// Shadows URLRequestJob's version of this method so we can grab cookies.
void NotifyHeadersComplete();
@@ -120,7 +121,6 @@ class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
bool GetRemoteEndpoint(IPEndPoint* endpoint) const override;
int GetResponseCode() const override;
void PopulateNetErrorDetails(NetErrorDetails* details) const override;
- std::unique_ptr<Filter> SetupFilter() const override;
bool CopyFragmentOnRedirect(const GURL& location) const override;
bool IsSafeRedirect(const GURL& location) override;
bool NeedsAuth() override;
@@ -145,7 +145,8 @@ class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
void ResetTimer();
void UpdatePacketReadTimes() override;
- void RecordPacketStats(FilterContext::StatisticSelector statistic) const;
+ void RecordPacketStats(
+ SdchPolicyDelegate::Context::StatisticSelector statistic) const;
// Starts the transaction if extensions using the webrequest API do not
// object.
@@ -240,7 +241,7 @@ class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
// When the transaction finished reading the request headers.
base::TimeTicks receive_headers_end_;
- std::unique_ptr<HttpFilterContext> filter_context_;
+ std::unique_ptr<SdchPolicyDelegate> sdch_delegate_;
CompletionCallback on_headers_received_callback_;

Powered by Google App Engine
This is Rietveld 408576698