Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: net/url_request/url_request_http_job.h

Issue 2373003003: Switch to use net::FilterSourceStream from net::Filter (Closed)
Patch Set: rebased onto sdch fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_file_job.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job.h
diff --git a/net/url_request/url_request_http_job.h b/net/url_request/url_request_http_job.h
index c9150ae697c602c6a70f57b527d34fcf30a2d891..df351a3d9afce594eea414ebe320f01c9e631dec 100644
--- a/net/url_request/url_request_http_job.h
+++ b/net/url_request/url_request_http_job.h
@@ -22,7 +22,7 @@
#include "net/base/net_export.h"
#include "net/base/sdch_manager.h"
#include "net/cookies/cookie_store.h"
-#include "net/filter/filter.h"
+#include "net/filter/sdch_policy_delegate.h"
#include "net/http/http_request_info.h"
#include "net/socket/connection_attempts.h"
#include "net/url_request/url_request_job.h"
@@ -50,7 +50,7 @@ class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
// Record Sdch specific packet stats. Public so that SdchPolicyDelegate can
// access it.
- void RecordPacketStats(FilterContext::StatisticSelector statistic) const;
+ void RecordPacketStats(SdchPolicyDelegate::StatisticSelector statistic) const;
protected:
URLRequestHttpJob(URLRequest* request,
@@ -64,6 +64,7 @@ class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
void Start() override;
void Kill() override;
void GetConnectionAttempts(ConnectionAttempts* out) const override;
+ std::unique_ptr<SourceStream> SetUpSourceStream() override;
RequestPriority priority() const {
return priority_;
@@ -77,7 +78,7 @@ class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
typedef base::RefCountedData<bool> SharedBoolean;
- class HttpFilterContext;
+ class SdchContext;
// Shadows URLRequestJob's version of this method so we can grab cookies.
void NotifyHeadersComplete();
@@ -124,7 +125,6 @@ class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
bool GetRemoteEndpoint(IPEndPoint* endpoint) const override;
int GetResponseCode() const override;
void PopulateNetErrorDetails(NetErrorDetails* details) const override;
- std::unique_ptr<Filter> SetupFilter() const override;
bool CopyFragmentOnRedirect(const GURL& location) const override;
bool IsSafeRedirect(const GURL& location) override;
bool NeedsAuth() override;
@@ -243,8 +243,6 @@ class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
// When the transaction finished reading the request headers.
base::TimeTicks receive_headers_end_;
- std::unique_ptr<HttpFilterContext> filter_context_;
-
CompletionCallback on_headers_received_callback_;
// We allow the network delegate to modify a copy of the response headers.
« no previous file with comments | « net/url_request/url_request_file_job.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698