Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: src/v8.gyp

Issue 2372983003: Turn libplatform into a component (Closed)
Patch Set: updates Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/libplatform/worker-thread.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/v8.gyp
diff --git a/src/v8.gyp b/src/v8.gyp
index a494fd6684022148001e2beee511a037e9944cd2..f23c579be777b9c3e778ef97e762223d063e84b8 100644
--- a/src/v8.gyp
+++ b/src/v8.gyp
@@ -2042,7 +2042,7 @@
},
{
'target_name': 'v8_libplatform',
- 'type': 'static_library',
+ 'type': '<(component)',
'variables': {
'optimize': 'max',
},
@@ -2056,6 +2056,7 @@
],
'sources': [
'../include/libplatform/libplatform.h',
+ '../include/libplatform/libplatform-export.h',
'../include/libplatform/v8-tracing.h',
'libplatform/default-platform.cc',
'libplatform/default-platform.h',
@@ -2077,6 +2078,12 @@
}, {
'toolsets': ['target'],
}],
+ ['component=="shared_library"', {
+ 'direct_dependent_settings': {
+ 'defines': [ 'USING_V8_PLATFORM_SHARED' ],
+ },
+ 'defines': [ 'BUILD_V8_PLATFORM_SHARED' ],
Michael Achenbach 2016/09/27 13:09:09 You called it BUILDING
+ }]
],
'direct_dependent_settings': {
'include_dirs': [
« no previous file with comments | « src/libplatform/worker-thread.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698