Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: include/libplatform/v8-tracing.h

Issue 2372983003: Turn libplatform into a component (Closed)
Patch Set: updates Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/libplatform/v8-tracing.h
diff --git a/include/libplatform/v8-tracing.h b/include/libplatform/v8-tracing.h
index 7646ea5489664300ec7ad64ea1dbce6451c15424..4eb29219ea42031cfc0170c6434e2c56db284464 100644
--- a/include/libplatform/v8-tracing.h
+++ b/include/libplatform/v8-tracing.h
@@ -9,13 +9,15 @@
#include <memory>
#include <vector>
+#include "libplatform/libplatform-export.h"
+
namespace v8 {
namespace platform {
namespace tracing {
const int kTraceMaxNumArgs = 2;
-class TraceObject {
+class V8_PLATFORM_EXPORT TraceObject {
public:
union ArgValue {
bool as_bool;
@@ -87,7 +89,7 @@ class TraceObject {
void operator=(const TraceObject&) = delete;
};
-class TraceWriter {
+class V8_PLATFORM_EXPORT TraceWriter {
public:
TraceWriter() {}
virtual ~TraceWriter() {}
@@ -102,7 +104,7 @@ class TraceWriter {
void operator=(const TraceWriter&) = delete;
};
-class TraceBufferChunk {
+class V8_PLATFORM_EXPORT TraceBufferChunk {
public:
explicit TraceBufferChunk(uint32_t seq);
@@ -126,7 +128,7 @@ class TraceBufferChunk {
void operator=(const TraceBufferChunk&) = delete;
};
-class TraceBuffer {
+class V8_PLATFORM_EXPORT TraceBuffer {
public:
TraceBuffer() {}
virtual ~TraceBuffer() {}
@@ -162,7 +164,7 @@ enum TraceRecordMode {
ECHO_TO_CONSOLE,
};
-class TraceConfig {
+class V8_PLATFORM_EXPORT TraceConfig {
public:
typedef std::vector<std::string> StringList;
@@ -200,7 +202,7 @@ class TraceConfig {
void operator=(const TraceConfig&) = delete;
};
-class TracingController {
+class V8_PLATFORM_EXPORT TracingController {
public:
enum Mode { DISABLED = 0, RECORDING_MODE };

Powered by Google App Engine
This is Rietveld 408576698