Chromium Code Reviews
DescriptionRevert of Add tests for PaintPropertyTreePrinter, remove path printers (patchset #2 id:20001 of https://codereview.chromium.org/2368783002/ )
Reason for revert:
This patch was correct but failed in combination with https://crrev.com/80f2dd56da341a600b19f74b45e0aaae52fdb1d7 and https://crrev.com/0abd71cfec612222822a4e4a1bb0bc89e937a9ce which landed very close to this patch. I'm going to roll this out instead of the other two to green the tree faster. I'll re-land with the simple fix tomorrow.
Original issue's description:
> Add tests for PaintPropertyTreePrinter, remove path printers
>
> This patch adds some basic testing of PaintPropertyTreePrinter which
> ensures trees can be print with and without root layer scrolling.
> Regular expressions have been used to focus on the tree structure and
> avoid dynamic output (e.g., pointer values).
>
> I am not aware of anyone using the path printers and have removed them
> to keep PaintPropertyTreePrinter lean & mean.
>
> BUG=645615
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/900408123237980d6b583c24b7e64d3b446910e8
> Cr-Commit-Position: refs/heads/master@{#420964}
TBR=chrishtr@chromium.org,szager@chromium.org,trchen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=645615
Committed: https://crrev.com/8dd17c6523d757f4e8075157c14cf2e661b1e1b9
Cr-Commit-Position: refs/heads/master@{#421112}
Patch Set 1 #
Messages
Total messages: 9 (4 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||