Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2372963002: Revert of Add tests for PaintPropertyTreePrinter, remove path printers (Closed)

Created:
4 years, 2 months ago by pdr.
Modified:
4 years, 2 months ago
Reviewers:
chrishtr, szager1, trchen
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org, Elly Fong-Jones, hajimehoshi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add tests for PaintPropertyTreePrinter, remove path printers (patchset #2 id:20001 of https://codereview.chromium.org/2368783002/ ) Reason for revert: This patch was correct but failed in combination with https://crrev.com/80f2dd56da341a600b19f74b45e0aaae52fdb1d7 and https://crrev.com/0abd71cfec612222822a4e4a1bb0bc89e937a9ce which landed very close to this patch. I'm going to roll this out instead of the other two to green the tree faster. I'll re-land with the simple fix tomorrow. Original issue's description: > Add tests for PaintPropertyTreePrinter, remove path printers > > This patch adds some basic testing of PaintPropertyTreePrinter which > ensures trees can be print with and without root layer scrolling. > Regular expressions have been used to focus on the tree structure and > avoid dynamic output (e.g., pointer values). > > I am not aware of anyone using the path printers and have removed them > to keep PaintPropertyTreePrinter lean & mean. > > BUG=645615 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Committed: https://crrev.com/900408123237980d6b583c24b7e64d3b446910e8 > Cr-Commit-Position: refs/heads/master@{#420964} TBR=chrishtr@chromium.org,szager@chromium.org,trchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=645615 Committed: https://crrev.com/8dd17c6523d757f4e8075157c14cf2e661b1e1b9 Cr-Commit-Position: refs/heads/master@{#421112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -172 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.h View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp View 3 chunks +56 lines, -56 lines 0 comments Download
D third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp View 1 chunk +0 lines, -109 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pdr.
Created Revert of Add tests for PaintPropertyTreePrinter, remove path printers
4 years, 2 months ago (2016-09-27 05:05:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372963002/1
4 years, 2 months ago (2016-09-27 05:05:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 05:06:11 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8dd17c6523d757f4e8075157c14cf2e661b1e1b9 Cr-Commit-Position: refs/heads/master@{#421112}
4 years, 2 months ago (2016-09-27 05:08:18 UTC) #7
engedy
4 years, 2 months ago (2016-09-27 08:52:34 UTC) #9
Message was sent while issue was closed.
WebKit Linux (dbg) had a bit of backlog, CC'ing EST and APAC sheriffs to make
sure they are not inclined to start reverting things as the failure is
webkit_unit_tests failure there is already resolved by this.

Powered by Google App Engine
This is Rietveld 408576698