third_party/WebKit/LayoutTests/fast/forms/select/select-remove-option-single.html - Issue 2372913002: fixed <select> element isn't updated after its single option removing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/select/select-remove-option-single.html

Issue 2372913002: fixed <select> element isn't updated after its single option removing. (Closed)

Patch Set: changed script activation point Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <title>Test for HTMLSelectElement.remove() on an Options object</title>
	tkent 2016/09/28 23:13:26 Please add <!DOCTYPE html> Please add <!DOCTYPE html>
	2

	3 <style type="text/css">

	4 select {
	tkent 2016/09/28 23:13:26 nit: Do not indent the whole content of <style>. i nit: Do not indent the whole content of <style>. i.e. <style> select { min-width: 100px; } </style>
	5 min-width: 100px;

	6 }

	7 </style>

	8

	9 <select>

	10 <option selected >hello</option>
	tkent 2016/09/28 23:13:26 A space after "selected" is unnecessary. A space after "selected" is unnecessary.
	11 </select>

	12

	13 <a herf="#">Remove option</a>

	14

	15 <script>

	16 window.addEventListener('load', function() {

	17 var removeLink = document.querySelector('a');

	18 removeLink.addEventListener('click', () => {

	19 document.querySelector('option').remove();

	20 });

	21 removeLink.click();
	tkent 2016/09/28 23:13:26 I don't think we need to click the <a>. Why don't I don't think we need to click the <a>. Why don't you just call document.querySelector('option').remove()? window.addEventListener('load', function() { document.querySelector('option').remove(); });
	22 });

	23 </script>

	24
	tkent 2016/09/28 23:13:26 This line is unnecessary. This line is unnecessary.
OLD	NEW