Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2372873002: [modules] Add tests for the name property of default-exported functions. (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Add tests for the name property of default-exported functions. R=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/841458036a43304746162862c0fe88a4ecbeb42f Cr-Commit-Position: refs/heads/master@{#39746}

Patch Set 1 #

Patch Set 2 : More #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -13 lines) Patch
A test/mjsunit/modules-default-name1.js View 1 chunk +10 lines, -0 lines 0 comments Download
A test/mjsunit/modules-default-name2.js View 1 chunk +10 lines, -0 lines 0 comments Download
A test/mjsunit/modules-default-name3.js View 1 chunk +10 lines, -0 lines 0 comments Download
A test/mjsunit/modules-default-name4.js View 1 chunk +10 lines, -0 lines 0 comments Download
A test/mjsunit/modules-default-name5.js View 1 chunk +10 lines, -0 lines 0 comments Download
A test/mjsunit/modules-default-name6.js View 1 chunk +10 lines, -0 lines 0 comments Download
A test/mjsunit/modules-default-name7.js View 1 chunk +11 lines, -0 lines 0 comments Download
A test/mjsunit/modules-default-name8.js View 1 1 chunk +10 lines, -0 lines 0 comments Download
A test/mjsunit/modules-default-name9.js View 1 1 chunk +10 lines, -0 lines 0 comments Download
A + test/mjsunit/modules-skip-default-name1.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/modules-skip-default-name2.js View 1 chunk +1 line, -3 lines 0 comments Download
A + test/mjsunit/modules-skip-default-name3.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/modules-skip-default-name4.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/modules-skip-default-name5.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/modules-skip-default-name6.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/modules-skip-default-name7.js View 1 chunk +1 line, -3 lines 0 comments Download
A + test/mjsunit/modules-skip-default-name8.js View 1 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/modules-skip-default-name9.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
neis
4 years, 2 months ago (2016-09-27 00:03:05 UTC) #1
adamk
Please add tests for the cases: export default function() {} and export default class {}
4 years, 2 months ago (2016-09-27 00:12:28 UTC) #2
neis
On 2016/09/27 00:12:28, adamk wrote: > Please add tests for the cases: > > export ...
4 years, 2 months ago (2016-09-27 00:19:30 UTC) #3
adamk
lgtm
4 years, 2 months ago (2016-09-27 00:20:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372873002/20001
4 years, 2 months ago (2016-09-27 00:20:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 00:48:20 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 00:48:40 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/841458036a43304746162862c0fe88a4ecbeb42f
Cr-Commit-Position: refs/heads/master@{#39746}

Powered by Google App Engine
This is Rietveld 408576698