Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2372853002: Revert of Size limit gtest collect (Closed)

Created:
4 years, 2 months ago by martiniss
Modified:
4 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Size limit gtest collect (patchset #2 id:20001 of https://codereview.chromium.org/2372783002/ ) Reason for revert: Might have caused https://crbug.com/650476 Original issue's description: > Size limit gtest collect > > BUG=634418 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/13fccd9dc8576ce524c2e44bd5513a6e822cae0e TBR=maruel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=634418 Committed: https://chromium.googlesource.com/chromium/tools/build/+/dcab1a31d35170b6dfcea53103b3fa147a100ab2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M scripts/slave/recipe_modules/swarming/resources/collect_gtest_task.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
martiniss
Created Revert of Size limit gtest collect
4 years, 2 months ago (2016-09-26 23:36:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372853002/1
4 years, 2 months ago (2016-09-26 23:36:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/dcab1a31d35170b6dfcea53103b3fa147a100ab2
4 years, 2 months ago (2016-09-26 23:36:14 UTC) #5
martiniss
4 years, 2 months ago (2016-09-27 00:01:16 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2372713003/ by martiniss@chromium.org.

The reason for reverting is: Trying again, since the original patch seemed to
fix the linux tryserver..

Powered by Google App Engine
This is Rietveld 408576698