Add ash devtools client

ash/common/wm_shell.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/wm_shell.h"
 
 #include <utility>
 
 #include "ash/common/accelerators/accelerator_controller.h"
 #include "ash/common/accelerators/ash_focus_manager_factory.h"
 #include "ash/common/accessibility_delegate.h"
+#include "ash/common/devtools/devtools_client_backend.h"
 #include "ash/common/focus_cycler.h"
 #include "ash/common/keyboard/keyboard_ui.h"
 #include "ash/common/new_window_delegate.h"
 #include "ash/common/palette_delegate.h"
 #include "ash/common/session/session_state_delegate.h"
 #include "ash/common/shelf/app_list_shelf_item_delegate.h"
 #include "ash/common/shelf/shelf_delegate.h"
 #include "ash/common/shelf/shelf_model.h"
 #include "ash/common/shelf/shelf_window_watcher.h"
 #include "ash/common/shell_delegate.h"
 #include "ash/common/shell_window_ids.h"
 #include "ash/common/system/brightness_control_delegate.h"
 #include "ash/common/system/keyboard_brightness_control_delegate.h"
 #include "ash/common/system/toast/toast_manager.h"
 #include "ash/common/system/tray/system_tray_delegate.h"
 #include "ash/common/system/tray/system_tray_notifier.h"
 #include "ash/common/wallpaper/wallpaper_controller.h"
 #include "ash/common/wallpaper/wallpaper_delegate.h"
 #include "ash/common/wm/immersive_context_ash.h"
 #include "ash/common/wm/maximize_mode/maximize_mode_controller.h"
 #include "ash/common/wm/mru_window_tracker.h"
 #include "ash/common/wm/overview/window_selector_controller.h"
 #include "ash/common/wm/root_window_finder.h"
 #include "ash/common/wm/system_modal_container_layout_manager.h"
 #include "ash/common/wm/window_cycle_controller.h"
 #include "ash/common/wm_root_window_controller.h"
 #include "ash/common/wm_window.h"
 #include "base/bind.h"
+#include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "ui/app_list/presenter/app_list_presenter.h"
+#include "ui/devtools/switches.h"
 #include "ui/display/display.h"
 #include "ui/views/focus/focus_manager_factory.h"
 
 #if defined(OS_CHROMEOS)
 #include "ash/common/system/chromeos/brightness/brightness_controller_chromeos.h"
 #include "ash/common/system/chromeos/keyboard_brightness_controller.h"
 #include "ash/common/system/chromeos/session/logout_confirmation_controller.h"
 #endif
 
 namespace ash {
@@ skipping 24 matching lines @@
   // Create the app list item in the shelf data model.
   AppListShelfItemDelegate::CreateAppListItemAndDelegate(shelf_model_.get());
 
   // Install the custom factory early on so that views::FocusManagers for Tray,
   // Shelf, and WallPaper could be created by the factory.
   views::FocusManagerFactory::Install(new AshFocusManagerFactory);
 
   new_window_delegate_.reset(delegate_->CreateNewWindowDelegate());
 
   wallpaper_controller_.reset(new WallpaperController(blocking_pool_));
+
+  // Start devtools server
+  bool remote_debugging_ = base::CommandLine::ForCurrentProcess()->HasSwitch(
+      ui::devtools::kEnableUiDevTools);
+  if (remote_debugging_) {
+    int port;
+    base::StringToInt(
+        base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
+            ui::devtools::kEnableUiDevTools),
+        &port);
+    devtools_server_.reset(new ui::devtools::UiDevToolsServer());
+    // TODO(mhashmi): Remove port + 1 when UiDevToolsServer becomes a service,
+    // this is to avoid mus/ash using the same port
+    devtools_server_->Start("127.0.0.1", port + 1);
+    std::unique_ptr<ui::devtools::protocol::DOM::Backend> backend(
+        new ui::devtools::AshDevToolsBackend(this));
+    std::unique_ptr<ui::devtools::UiDevToolsClient> devtools_client(
+        new ui::devtools::UiDevToolsClient("Ash", devtools_server_.get()));
+    devtools_client->AddDOMBackend(std::move(backend));
+    devtools_server_->AttachClient(std::move(devtools_client));
+  }

[sadrul, 2016/10/17 16:19:00]

Can some of this code be moved into ui/devtools/? For example, the code here
could look like:

 devtools_server_ = ui::UiDevToolsServer::Create();
 if (devtools_server_) {
    ... register backend, client etc.
 }

ui::UiDevToolsServer::Create() would look at the flag to decide whether or not
to start the server, and what port to use etc.

[Sarmad Hashmi, 2016/10/17 19:11:48]

This is a great idea. Done!

 }
 
 void WmShell::Shutdown() {
   // These members access WmShell in their destructors.
   wallpaper_controller_.reset();
   accessibility_delegate_.reset();
 
   // ShelfWindowWatcher has window observers and a pointer to the shelf model.
   shelf_window_watcher_.reset();
   // ShelfItemDelegate subclasses it owns have complex cleanup to run (e.g. ARC
@@ skipping 252 matching lines @@
 void WmShell::DeleteToastManager() {
   toast_manager_.reset();
 }
 
 void WmShell::SetAcceleratorController(
     std::unique_ptr<AcceleratorController> accelerator_controller) {
   accelerator_controller_ = std::move(accelerator_controller);
 }
 
 }  // namespace ash