remoting/host/it2me/it2me_confirmation_dialog_chromeos.cc - Issue 2372833002: Removing It2MeConfirmationDialogFactory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/host/it2me/it2me_confirmation_dialog_chromeos.cc

Issue 2372833002: Removing It2MeConfirmationDialogFactory (Closed)

Patch Set: Cleaning up formatting Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include <memory>	5 #include <memory>

6 #include <string>	6 #include <string>

7	7

8 #include "base/bind.h"	8 #include "base/bind.h"

9 #include "base/callback.h"	9 #include "base/callback.h"

10 #include "base/callback_helpers.h"	10 #include "base/callback_helpers.h"

(...skipping 50 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
61 message_box_->Show();	61 message_box_->Show();

62 }	62 }

63	63

64 void It2MeConfirmationDialogChromeOS::OnMessageBoxResult(	64 void It2MeConfirmationDialogChromeOS::OnMessageBoxResult(

65 MessageBox::Result result) {	65 MessageBox::Result result) {

66 message_box_->Hide();	66 message_box_->Hide();

67 base::ResetAndReturn(&callback_).Run(result == MessageBox::OK ?	67 base::ResetAndReturn(&callback_).Run(result == MessageBox::OK ?

68 Result::OK : Result::CANCEL);	68 Result::OK : Result::CANCEL);

69 }	69 }

70	70

71 std::unique_ptr<It2MeConfirmationDialog>	71 std::unique_ptr<It2MeConfirmationDialog> It2MeConfirmationDialog::Create() {
	Sergey Ulanov 2016/09/27 17:48:40 add "// static" on the line above to make it clear add "// static" on the line above to make it clear that this is a static function. Same in other files that define this function. joedow 2016/09/27 20:05:38 Done. Show quoted text On 2016/09/27 17:48:40, Sergey Ulanov wrote: > add "// static" on the line above to make it clear that this is a static > function. Same in other files that define this function. Done.
72 It2MeConfirmationDialogFactory::Create() {

73 return base::MakeUnique<It2MeConfirmationDialogChromeOS>();	72 return base::MakeUnique<It2MeConfirmationDialogChromeOS>();

74 }	73 }

75	74

76 } // namespace remoting	75 } // namespace remoting

OLD	NEW