Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2372823004: [wasm] asm.js: Work around parser converting !0 and !1 to boolean. (Closed)

Created:
4 years, 2 months ago by bradnelson
Modified:
4 years, 2 months ago
Reviewers:
aseemgarg, bradn, John
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] asm.js: Work around parser converting !0 and !1 to boolean. !0 -> true and !1 -> false etc in the parser. This clashes with some of the typing logic in asm.js, and can show up in some real programs in the wild (at least in past asm.js versions). BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 R=aseemgarg@chromium.org,jpp@chromium.org Committed: https://crrev.com/53b228239e5074d6e1ff0b477168f0d03e3a8e40 Cr-Commit-Position: refs/heads/master@{#39798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M src/asmjs/asm-typer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/asmjs/asm-wasm-builder.cc View 2 chunks +15 lines, -1 line 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
bradn
4 years, 2 months ago (2016-09-27 22:53:54 UTC) #4
aseemgarg
lgtm
4 years, 2 months ago (2016-09-27 23:02:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372823004/1
4 years, 2 months ago (2016-09-27 23:03:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 23:20:06 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 23:20:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53b228239e5074d6e1ff0b477168f0d03e3a8e40
Cr-Commit-Position: refs/heads/master@{#39798}

Powered by Google App Engine
This is Rietveld 408576698