Source/core/dom/DocumentMarker.h - Issue 23728006: addMarker() optimizations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/DocumentMarker.h

Issue 23728006: addMarker() optimizations. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: More review commments (style, additions: upper/lower bounding where easily possible, creating the l… Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/DocumentMarker.h

diff --git a/Source/core/dom/DocumentMarker.h b/Source/core/dom/DocumentMarker.h

index b6072b9701c76607f4cd735443d80bbe8d2538b9..cbebc4fc13f60cfa6483b1ab3fb1f88ec1d0a66f 100644

--- a/Source/core/dom/DocumentMarker.h

+++ b/Source/core/dom/DocumentMarker.h

@@ -38,10 +38,17 @@ class DocumentMarkerDetails;

// for all types other than type TextMatch.

class DocumentMarker {

public:

+ enum MarkerTypeIndex {

+ SpellingMarkerIndex = 0,

+ GramarMarkerIndex,

+ TextMatchMarkerIndex,

+ MarkerTypeIndexesCount

+ };

enum MarkerType {

- Spelling = 1 << 0,

- Grammar = 1 << 1,

- TextMatch = 1 << 2

+ Spelling = 1 << SpellingMarkerIndex,

+ Grammar = 1 << GramarMarkerIndex,

+ TextMatch = 1 << TextMatchMarkerIndex

};

class MarkerTypes {