Source/core/dom/DocumentMarkerController.h - Issue 23728006: addMarker() optimizations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/DocumentMarkerController.h

Issue 23728006: addMarker() optimizations. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase & split marker list by marker type. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/DocumentMarkerController.h

diff --git a/Source/core/dom/DocumentMarkerController.h b/Source/core/dom/DocumentMarkerController.h

index 0b14aaa579ca6fab383f9ed7f4cd4597092bef23..d7da98727f07100d9b4188f5b31d7201c82f1ebd 100644

--- a/Source/core/dom/DocumentMarkerController.h

+++ b/Source/core/dom/DocumentMarkerController.h

@@ -87,7 +87,9 @@ private:

void addMarker(Node*, const DocumentMarker&);

typedef Vector<RenderedDocumentMarker> MarkerList;

- typedef HashMap<RefPtr<Node>, OwnPtr<MarkerList> > MarkerMap;

+ typedef Vector<OwnPtr<MarkerList>, DocumentMarker::MarkerTypeIndexesCount> MarkerLists;

+ typedef HashMap<RefPtr<Node>, OwnPtr<MarkerLists> > MarkerMap;

+ void mergeOverlapping(MarkerList*, DocumentMarker&);

bool possiblyHasMarkers(DocumentMarker::MarkerTypes);

void removeMarkersFromList(MarkerMap::iterator, DocumentMarker::MarkerTypes);