Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2372783002: Size limit gtest collect (Closed)

Created:
4 years, 2 months ago by martiniss
Modified:
4 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : parens #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M scripts/slave/recipe_modules/swarming/resources/collect_gtest_task.py View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
martiniss
4 years, 2 months ago (2016-09-26 21:01:52 UTC) #2
M-A Ruel
lgtm https://codereview.chromium.org/2372783002/diff/1/scripts/slave/recipe_modules/swarming/resources/collect_gtest_task.py File scripts/slave/recipe_modules/swarming/resources/collect_gtest_task.py (right): https://codereview.chromium.org/2372783002/diff/1/scripts/slave/recipe_modules/swarming/resources/collect_gtest_task.py#newcode107 scripts/slave/recipe_modules/swarming/resources/collect_gtest_task.py:107: raise ValueError ()
4 years, 2 months ago (2016-09-26 21:04:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372783002/20001
4 years, 2 months ago (2016-09-26 21:06:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/tools/build/+/13fccd9dc8576ce524c2e44bd5513a6e822cae0e
4 years, 2 months ago (2016-09-26 21:09:59 UTC) #9
martiniss
4 years, 2 months ago (2016-09-26 23:36:05 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2372853002/ by martiniss@chromium.org.

The reason for reverting is: Might have caused https://crbug.com/650476.

Powered by Google App Engine
This is Rietveld 408576698