tools/perf/benchmarks/silk_flags.py - Issue 2372753003: Remove obsolete references to threaded-compositing and impl-side-painting flags.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/benchmarks/silk_flags.py

Issue 2372753003: Remove obsolete references to threaded-compositing and impl-side-painting flags. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/test/gpu/gpu_tests/gpu_rasterization.py ('K') | « content/test/gpu/gpu_tests/gpu_rasterization.py ('k') | tools/perf/measurements/rasterize_and_record_micro.py » ('j') | tools/perf/measurements/rasterize_and_record_micro.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5	5

6 def CustomizeBrowserOptionsForSoftwareRasterization(options):	6 def CustomizeBrowserOptionsForSoftwareRasterization(options):

7 """Enables flags needed for forced software rasterization."""	7 """Enables flags needed for forced software rasterization."""

8 options.AppendExtraBrowserArgs('--disable-gpu-rasterization')	8 options.AppendExtraBrowserArgs('--disable-gpu-rasterization')

9	9

10	10

11 def CustomizeBrowserOptionsForGpuRasterization(options):	11 def CustomizeBrowserOptionsForGpuRasterization(options):

12 """Enables flags needed for forced GPU rasterization using Ganesh."""	12 """Enables flags needed for forced GPU rasterization using Ganesh."""

13 options.AppendExtraBrowserArgs('--enable-threaded-compositing')	13 options.AppendExtraBrowserArgs('--enable-threaded-compositing')
	danakj 2016/09/26 21:39:29 Ditto Ditto wkorman 2016/09/26 22:18:54 Done. Show quoted text On 2016/09/26 21:39:29, danakj wrote: > Ditto Done.
14 options.AppendExtraBrowserArgs('--enable-impl-side-painting')

15 options.AppendExtraBrowserArgs('--force-gpu-rasterization')	14 options.AppendExtraBrowserArgs('--force-gpu-rasterization')

16	15

17	16

18 def CustomizeBrowserOptionsForSyncScrolling(options):	17 def CustomizeBrowserOptionsForSyncScrolling(options):

19 """Enables flags needed for synchronous (main thread) scrolling."""	18 """Enables flags needed for synchronous (main thread) scrolling."""

20 options.AppendExtraBrowserArgs('--disable-threaded-scrolling')	19 options.AppendExtraBrowserArgs('--disable-threaded-scrolling')

21	20

22 def CustomizeBrowserOptionsForThreadTimes(options):	21 def CustomizeBrowserOptionsForThreadTimes(options):

23 """Disables options known to cause noise in thread times"""	22 """Disables options known to cause noise in thread times"""

24 # Remove once crbug.com/621128 is fixed.	23 # Remove once crbug.com/621128 is fixed.

25 options.AppendExtraBrowserArgs('--disable-top-sites')	24 options.AppendExtraBrowserArgs('--disable-top-sites')

OLD	NEW