Cleanup fetch, fix missing network flake instances

Cleanup fetch, fix missing network flake instances

Make the fetch command identify flake based on the Git subcommand that
is being invoked.

The fetch Git sequence is also currently a bit sloppy. Refactor the Git
invocations and the related tests to make the code cleaner and more
testable.

BUG=chromium:650355
TEST=unit

Committed: https://github.com/luci/recipes-py/commit/79cf78db1a3c32c7730f3e9006825a95261abe06

[dnj, 2016-09-26 20:10:13]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org, martiniss@chromium.org

[dnj, 2016-09-26 20:10:14]

PTAL

[martiniss, 2016-09-26 22:58:02]

looks pretty good

https://codereview.chromium.org/2372753002/diff/20001/recipe_engine/unittests...
File recipe_engine/unittests/fetch_test.py (right):

https://codereview.chromium.org/2372753002/diff/20001/recipe_engine/unittests...
recipe_engine/unittests/fetch_test.py:23: class TestGit(unittest.TestCase):
Can you add a test case like in the bug? :)

[dnj, 2016-09-26 23:48:57]

https://codereview.chromium.org/2372753002/diff/20001/recipe_engine/unittests...
File recipe_engine/unittests/fetch_test.py (right):

https://codereview.chromium.org/2372753002/diff/20001/recipe_engine/unittests...
recipe_engine/unittests/fetch_test.py:23: class TestGit(unittest.TestCase):
On 2016/09/26 22:58:02, martiniss wrote:
> Can you add a test case like in the bug? :)

Done.

[martiniss, 2016-09-26 23:50:38]

lgtm

[dnj, 2016-09-27 00:10:03]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2016-09-27 00:10:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 00:13:06]

Description was changed from

==========
Cleanup fetch, fix missing network flake instances

Make the fetch command identify flake based on the Git subcommand that
is being invoked.

The fetch Git sequence is also currently a bit sloppy. Refactor the Git
invocations and the related tests to make the code cleaner and more
testable.

BUG=chromium:650355
TEST=unit
==========

to

==========
Cleanup fetch, fix missing network flake instances

Make the fetch command identify flake based on the Git subcommand that
is being invoked.

The fetch Git sequence is also currently a bit sloppy. Refactor the Git
invocations and the related tests to make the code cleaner and more
testable.

BUG=chromium:650355
TEST=unit

Committed:
https://github.com/luci/recipes-py/commit/79cf78db1a3c32c7730f3e9006825a95261...
==========

[commit-bot: I haz the power, 2016-09-27 00:13:07]

Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/79cf78db1a3c32c7730f3e9006825a95261...