Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2372733002: [parser] Refactor of (Parse|Desugar)*(Async|Arrow)* (Closed)

Created:
4 years, 2 months ago by nickie
Modified:
4 years, 2 months ago
Reviewers:
adamk, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Refactor of (Parse|Desugar)*(Async|Arrow)* This patch moves the following parsing method to ParserBase: - DesugarAsyncFunctionBody, renamed to ParseAsyncFunctionBody - ParseAsyncFunctionExpression, renamed to ParseAsyncFunctionLiteral - ParseAsyncFunctionDeclaration It renames the parser implementation methods: - ParseArrowFunctionFormalParameterList -> DeclareArrowFunctionFormalParameters - ParseArrowFunctionFormalParameters -> AddArrowFunctionFormalParameters It also eliminates method ParseAsyncArrowSingleExpressionBody. R=adamk@chromium.org, marja@chromium.org BUG= LOG=N Committed: https://crrev.com/dfb90f7c6248d782ee8d33ece67e4db24c791c03 Cr-Commit-Position: refs/heads/master@{#39788}

Patch Set 1 : Just moving code (broken) #

Patch Set 2 : The real patch #

Patch Set 3 : Change after offline discussion with reviewers #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -187 lines) Patch
M src/parsing/parser.h View 1 2 3 6 chunks +13 lines, -24 lines 0 comments Download
M src/parsing/parser.cc View 1 2 3 7 chunks +52 lines, -95 lines 0 comments Download
M src/parsing/parser-base.h View 1 2 3 11 chunks +96 lines, -7 lines 0 comments Download
M src/parsing/preparser.h View 1 2 3 4 chunks +9 lines, -11 lines 0 comments Download
M src/parsing/preparser.cc View 1 2 3 3 chunks +0 lines, -50 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
nickie
4 years, 2 months ago (2016-09-26 18:39:29 UTC) #1
adamk
lgtm
4 years, 2 months ago (2016-09-26 19:15:01 UTC) #6
marja
lgtm
4 years, 2 months ago (2016-09-27 07:29:34 UTC) #7
nickie
Following offline discussions with Marja and Toon, the call to scope_snapshot.Reparent was removed from Parser::DeclareArrowFunctionFormalParameters ...
4 years, 2 months ago (2016-09-27 17:12:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372733002/60001
4 years, 2 months ago (2016-09-27 17:30:51 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-27 18:02:05 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 18:02:32 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/dfb90f7c6248d782ee8d33ece67e4db24c791c03
Cr-Commit-Position: refs/heads/master@{#39788}

Powered by Google App Engine
This is Rietveld 408576698