Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2372713003: Reland of Size limit gtest collect (Closed)

Created:
4 years, 2 months ago by martiniss
Modified:
4 years, 2 months ago
Reviewers:
Vadim Sh., M-A Ruel
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Reland of Size limit gtest collect (patchset #1 id:1 of https://codereview.chromium.org/2372853002/ ) Reason for revert: Trying again, since the original patch seemed to fix the linux tryserver. Original issue's description: > Revert of Size limit gtest collect (patchset #2 id:20001 of https://codereview.chromium.org/2372783002/ ) > > Reason for revert: > Might have caused https://crbug.com/650476 > > Original issue's description: > > Size limit gtest collect > > > > BUG=634418 > > > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/13fccd9dc8576ce524c2e44bd5513a6e822cae0e > > TBR=maruel@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=634418 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/dcab1a31d35170b6dfcea53103b3fa147a100ab2 TBR=maruel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=634418 Committed: https://chromium.googlesource.com/chromium/tools/build/+/40e9906b197269352a29f4bf2d0841bfe948d9b7

Patch Set 1 #

Patch Set 2 : Fix size limit. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M scripts/slave/recipe_modules/swarming/resources/collect_gtest_task.py View 1 1 chunk +8 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (3 generated)
martiniss
Created Reland of Size limit gtest collect
4 years, 2 months ago (2016-09-27 00:01:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372713003/40001
4 years, 2 months ago (2016-09-27 00:06:34 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/tools/build/+/40e9906b197269352a29f4bf2d0841bfe948d9b7
4 years, 2 months ago (2016-09-27 00:06:42 UTC) #5
Vadim Sh.
4 years, 2 months ago (2016-09-27 00:10:56 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/2372713003/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/swarming/resources/collect_gtest_task.py
(right):

https://codereview.chromium.org/2372713003/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/swarming/resources/collect_gtest_task.py:108: if
filesize > OUTPUT_JSON_SIZE_LIMIT:
please log this to stderr

https://codereview.chromium.org/2372713003/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/swarming/resources/collect_gtest_task.py:113:
except (IOError, ValueError):
catch OSError here, since os.stat can raise it now if 'path' is missing

Powered by Google App Engine
This is Rietveld 408576698