LogDog: Split CLI tool into package and main.

LogDog: Split CLI tool into package and main.

Split most of the "logdog" CLI tool into a Go package called "cli".
Allow this to be called externally and accept default parameters. Wire
up a default version of the tool that supplies no default parameters.
This will function the same as the previous "logdog" tool.

The intent of this change is to have an Infra-specific version of the
tool that is built.

BUG=chromium:650684
TEST=None

Committed: https://github.com/luci/luci-go/commit/e0e407209a72f692ef4de3908753e308d4ab798b

[dnj, 2016-09-27 17:31:26]

dnj@chromium.org changed reviewers:
+ estaab@chromium.org, vadimsh@chromium.org

[dnj, 2016-09-27 17:31:27]

PTAL. This is fairly trivial.

[Vadim Sh., 2016-09-27 17:58:35]

lgtm with nit

https://codereview.chromium.org/2372703005/diff/1/logdog/client/cli/main.go
File logdog/client/cli/main.go (right):

https://codereview.chromium.org/2372703005/diff/1/logdog/client/cli/main.go#n...
logdog/client/cli/main.go:48: // host is the host name of the Coordinator
service to interface with.
this comment is stale

[dnj, 2016-09-27 18:13:42]

Awesome, thanks!

https://codereview.chromium.org/2372703005/diff/1/logdog/client/cli/main.go
File logdog/client/cli/main.go (right):

https://codereview.chromium.org/2372703005/diff/1/logdog/client/cli/main.go#n...
logdog/client/cli/main.go:48: // host is the host name of the Coordinator
service to interface with.
On 2016/09/27 17:58:35, Vadim Sh. wrote:
> this comment is stale

Done.

[dnj, 2016-09-27 18:13:45]

The CQ bit was checked by dnj@chromium.org

[dnj, 2016-09-27 18:13:46]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2372703005/#ps20001
(title: "Fix comment.")

[commit-bot: I haz the power, 2016-09-27 18:13:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 18:23:09]

Description was changed from

==========
LogDog: Split CLI tool into package and main.

Split most of the "logdog" CLI tool into a Go package called "cli".
Allow this to be called externally and accept default parameters. Wire
up a default version of the tool that supplies no default parameters.
This will function the same as the previous "logdog" tool.

The intent of this change is to have an Infra-specific version of the
tool that is built.

BUG=chromium:650684
TEST=None
==========

to

==========
LogDog: Split CLI tool into package and main.

Split most of the "logdog" CLI tool into a Go package called "cli".
Allow this to be called externally and accept default parameters. Wire
up a default version of the tool that supplies no default parameters.
This will function the same as the previous "logdog" tool.

The intent of this change is to have an Infra-specific version of the
tool that is built.

BUG=chromium:650684
TEST=None

Committed:
https://github.com/luci/luci-go/commit/e0e407209a72f692ef4de3908753e308d4ab798b
==========

[commit-bot: I haz the power, 2016-09-27 18:23:10]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/e0e407209a72f692ef4de3908753e308d4ab798b