Issue 23727006: performChange no longer takes a |receiver| argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23727006: performChange no longer takes a |receiver| argument (Closed)

Created:
7 years, 3 months ago by rafaelw

Modified:
7 years, 3 months ago

Reviewers:
rossberg

CC:
v8-dev, arv (Not doing code reviews), adamk

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

performChange no longer takes a |receiver| argument. The spec omits the receiver arg with the idea arrow functions with lexical |this| will obviate the need for it. BUG= R=rossberg@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16644

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -38 lines)			Patch
	M	src/object-observe.js	View		3 chunks	+3 lines, -9 lines	1 comment	Download
	M	test/mjsunit/harmony/object-observe.js	View		6 chunks	+29 lines, -29 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rafaelw

https://codereview.chromium.org/23727006/diff/1/src/object-observe.js File src/object-observe.js (right): https://codereview.chromium.org/23727006/diff/1/src/object-observe.js#newcode517 src/object-observe.js:517: %_CallFunction(void 0, delivered, callback); Note: For consistency, both function ...

7 years, 3 months ago (2013-09-10 18:30:42 UTC) #1

rossberg

7 years, 3 months ago (2013-09-11 10:53:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16644 (presubmit successful).

Expand Messages | Collapse Messages