Allow ImportantFileWriter to take in a pre-write callback.

Allow ImportantFileWriter to take in a pre-write callback.

This is in addition to the existing post-write callback.
Also move JsonPrefStore's registration method from public to private and
make SerializeData call it.
The PrefHashFilter currently returns a pair of empty callbacks.

BUG=624858
Committed: https://crrev.com/c503d69650b9ecb3dbe45c44af03b3af8d347250
Cr-Commit-Position: refs/heads/master@{#421612}

[proberge, 2016-09-26 21:20:44]

Description was changed from

==========
Allow ImportantFileWriter to take in a pre-write callback.

This is in addition to the existing post-write callback.
Also move JsonPrefStore's registration method from public to private and
make SerializeData call it.
The PrefHashFilter currently returns a pair of empty callbacks.

BUG=624858
==========

to

==========
Allow ImportantFileWriter to take in a pre-write callback.

This is in addition to the existing post-write callback.
Also move JsonPrefStore's registration method from public to private and
make SerializeData call it.
The PrefHashFilter currently returns a pair of empty callbacks.

BUG=624858
==========

[proberge, 2016-09-26 21:20:45]

proberge@chromium.org changed reviewers:
+ dcheng@chromium.org, gab@chromium.org

[proberge, 2016-09-26 21:21:25]

PTAL

[gab, 2016-09-27 14:07:25]

lgtm

[dcheng, 2016-09-27 23:29:51]

LGTM

[proberge, 2016-09-28 14:09:29]

The CQ bit was checked by proberge@chromium.org

[commit-bot: I haz the power, 2016-09-28 14:09:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 14:16:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 14:16:35]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[proberge, 2016-09-28 14:23:45]

The CQ bit was checked by proberge@chromium.org

[commit-bot: I haz the power, 2016-09-28 14:24:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 14:25:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 14:25:34]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[proberge, 2016-09-28 15:15:21]

The CQ bit was checked by proberge@chromium.org

[commit-bot: I haz the power, 2016-09-28 15:15:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 15:52:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 15:52:19]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[proberge, 2016-09-28 18:12:46]

The CQ bit was checked by proberge@chromium.org

[proberge, 2016-09-28 18:12:46]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2372663003/#ps20001
(title: "Add a WaitableEvent to fix a race condition in
CallbackRunsOnWriterThread")

[commit-bot: I haz the power, 2016-09-28 18:13:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-09-28 18:15:36]

PS2 lgtm as well

[dcheng, 2016-09-28 18:23:19]

still lgtm

[commit-bot: I haz the power, 2016-09-28 19:51:30]

Description was changed from

==========
Allow ImportantFileWriter to take in a pre-write callback.

This is in addition to the existing post-write callback.
Also move JsonPrefStore's registration method from public to private and
make SerializeData call it.
The PrefHashFilter currently returns a pair of empty callbacks.

BUG=624858
==========

to

==========
Allow ImportantFileWriter to take in a pre-write callback.

This is in addition to the existing post-write callback.
Also move JsonPrefStore's registration method from public to private and
make SerializeData call it.
The PrefHashFilter currently returns a pair of empty callbacks.

BUG=624858
==========

[commit-bot: I haz the power, 2016-09-28 19:51:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-28 19:55:10]

Description was changed from

==========
Allow ImportantFileWriter to take in a pre-write callback.

This is in addition to the existing post-write callback.
Also move JsonPrefStore's registration method from public to private and
make SerializeData call it.
The PrefHashFilter currently returns a pair of empty callbacks.

BUG=624858
==========

to

==========
Allow ImportantFileWriter to take in a pre-write callback.

This is in addition to the existing post-write callback.
Also move JsonPrefStore's registration method from public to private and
make SerializeData call it.
The PrefHashFilter currently returns a pair of empty callbacks.

BUG=624858

Committed: https://crrev.com/c503d69650b9ecb3dbe45c44af03b3af8d347250
Cr-Commit-Position: refs/heads/master@{#421612}
==========

[commit-bot: I haz the power, 2016-09-28 19:55:11]

Patchset 2 (id:??) landed as
https://crrev.com/c503d69650b9ecb3dbe45c44af03b3af8d347250
Cr-Commit-Position: refs/heads/master@{#421612}