Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2372653004: Clean up comments and docstrings in webkitpy.common.system.logtesting. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up comments and docstrings in webkitpy.common.system.logtesting. This CL is a minor clean-up CL, and only touches comments and whitespace. In this CL: - Make formatting consistent with other modules - Remove FIXME note about renaming LoggingTestCase to LoggingTestCaseBase, since in practice LoggingTestCase is not interpreted as a test case since the logtesting module doesn't end in _unittest, and even if it were, LoggingTestCase has no test methods. Committed: https://crrev.com/832443eec1ac13b31d044967e8e36469bc4d28c5 Cr-Commit-Position: refs/heads/master@{#421331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -74 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/logtesting.py View 7 chunks +62 lines, -74 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
qyearsley
4 years, 2 months ago (2016-09-27 17:15:37 UTC) #3
jeffcarp
On 2016/09/27 at 17:15:37, qyearsley wrote: > lgtm :D
4 years, 2 months ago (2016-09-27 20:48:31 UTC) #8
jeffcarp
On 2016/09/27 at 20:48:31, jeffcarp wrote: > On 2016/09/27 at 17:15:37, qyearsley wrote: > > ...
4 years, 2 months ago (2016-09-27 20:49:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372653004/1
4 years, 2 months ago (2016-09-27 20:49:40 UTC) #11
jeffcarp
On 2016/09/27 at 20:49:40, commit-bot wrote: > CQ is trying da patch. Follow status at ...
4 years, 2 months ago (2016-09-27 20:51:57 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 20:56:24 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 21:01:22 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/832443eec1ac13b31d044967e8e36469bc4d28c5
Cr-Commit-Position: refs/heads/master@{#421331}

Powered by Google App Engine
This is Rietveld 408576698