Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: components/browser_watcher/watcher_metrics_provider_win.cc

Issue 2372633002: Use the correct product/version for postmortem reports (Closed)
Patch Set: Address clang errors Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/watcher_metrics_provider_win.cc
diff --git a/components/browser_watcher/watcher_metrics_provider_win.cc b/components/browser_watcher/watcher_metrics_provider_win.cc
index c6ab669a03d5efef3a5a21f96630b127ea6ea490..5ed372d07e258bdd7d6cf1be06eb637a1b69f5ed 100644
--- a/components/browser_watcher/watcher_metrics_provider_win.cc
+++ b/components/browser_watcher/watcher_metrics_provider_win.cc
@@ -217,12 +217,14 @@ WatcherMetricsProviderWin::WatcherMetricsProviderWin(
const base::string16& registry_path,
const base::FilePath& user_data_dir,
const base::FilePath& crash_dir,
+ const GetExecutableDetailsCallback& exe_details_cb,
base::TaskRunner* io_task_runner)
: recording_enabled_(false),
cleanup_scheduled_(false),
registry_path_(registry_path),
user_data_dir_(user_data_dir),
crash_dir_(crash_dir),
+ exe_details_cb_(exe_details_cb),
io_task_runner_(io_task_runner),
weak_ptr_factory_(this) {
DCHECK(io_task_runner_);
@@ -309,12 +311,14 @@ void WatcherMetricsProviderWin::CollectPostmortemReportsOnBlockingPool() {
return;
}
- // Note: not caching the histogram pointer as this function isn't expected to
- // be called multiple times.
LogCollectionInitStatus(INIT_SUCCESS);
// TODO(manzagop): fix incorrect version attribution on update.
- PostmortemReportCollector collector;
+ base::string16 product_name, version_number, channel_name;
+ exe_details_cb_.Run(&product_name, &version_number, &channel_name);
+ PostmortemReportCollector collector(base::UTF16ToUTF8(product_name),
+ base::UTF16ToUTF8(version_number),
+ base::UTF16ToUTF8(channel_name));
collector.CollectAndSubmitForUpload(stability_dir, GetStabilityFilePattern(),
excluded_debug_files,
crashpad_database.get());

Powered by Google App Engine
This is Rietveld 408576698