Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: components/browser_watcher/postmortem_report_collector_unittest.cc

Issue 2372633002: Use the correct product/version for postmortem reports (Closed)
Patch Set: Address clang errors Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/postmortem_report_collector_unittest.cc
diff --git a/components/browser_watcher/postmortem_report_collector_unittest.cc b/components/browser_watcher/postmortem_report_collector_unittest.cc
index e48b6b8ea3dfa6340499e7b962a37d47d068d4dd..fa99e3a630b7a27dfcb8c568d6b6fb789b44009b 100644
--- a/components/browser_watcher/postmortem_report_collector_unittest.cc
+++ b/components/browser_watcher/postmortem_report_collector_unittest.cc
@@ -46,6 +46,10 @@ using testing::SetArgPointee;
namespace {
+const char kProductName[] = "TestProduct";
+const char kVersionNumber[] = "TestVersionNumber";
+const char kChannelName[] = "TestChannel";
+
// Exposes a public constructor in order to create a dummy database.
class MockCrashReportDatabase : public CrashReportDatabase {
public:
@@ -91,7 +95,8 @@ class MockCrashReportDatabase : public CrashReportDatabase {
// Used for testing CollectAndSubmitForUpload.
class MockPostmortemReportCollector : public PostmortemReportCollector {
public:
- MockPostmortemReportCollector() {}
+ MockPostmortemReportCollector()
+ : PostmortemReportCollector(kProductName, kVersionNumber, kChannelName) {}
// A function that returns a unique_ptr cannot be mocked, so mock a function
// that returns a raw pointer instead.
@@ -263,7 +268,8 @@ TEST(PostmortemReportCollectorTest, GetDebugStateFilePaths) {
ASSERT_NE(file.get(), nullptr);
}
- PostmortemReportCollector collector;
+ PostmortemReportCollector collector(kProductName, kVersionNumber,
+ kChannelName);
EXPECT_THAT(
collector.GetDebugStateFilePaths(
temp_dir.path(), FILE_PATH_LITERAL("foo*.pma"), excluded_paths),
@@ -282,7 +288,8 @@ TEST(PostmortemReportCollectorTest, CollectEmptyFile) {
ASSERT_TRUE(PathExists(file_path));
// Validate collection: an empty file cannot suppport an analyzer.
- PostmortemReportCollector collector;
+ PostmortemReportCollector collector(kProductName, kVersionNumber,
+ kChannelName);
std::unique_ptr<StabilityReport> report;
ASSERT_EQ(PostmortemReportCollector::ANALYZER_CREATION_FAILED,
collector.Collect(file_path, &report));
@@ -307,7 +314,8 @@ TEST(PostmortemReportCollectorTest, CollectRandomFile) {
// Validate collection: random content appears as though there is not
// stability data.
- PostmortemReportCollector collector;
+ PostmortemReportCollector collector(kProductName, kVersionNumber,
+ kChannelName);
std::unique_ptr<StabilityReport> report;
ASSERT_EQ(PostmortemReportCollector::DEBUG_FILE_NO_DATA,
collector.Collect(file_path, &report));
@@ -401,7 +409,8 @@ class PostmortemReportCollectorCollectionTest : public testing::Test {
TEST_F(PostmortemReportCollectorCollectionTest, CollectSuccess) {
// Validate collection returns the expected report.
- PostmortemReportCollector collector;
+ PostmortemReportCollector collector(kProductName, kVersionNumber,
+ kChannelName);
std::unique_ptr<StabilityReport> report;
ASSERT_EQ(PostmortemReportCollector::SUCCESS,
collector.Collect(debug_file_path(), &report));
« no previous file with comments | « components/browser_watcher/postmortem_report_collector.cc ('k') | components/browser_watcher/watcher_metrics_provider_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698